Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make turbomodule/core/jni:jni depend on FBJNI_TARGET

Browse Source 
Summary:
`fbsource//xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni:jni` is a shared library that depends on `fbjni` (also another shared library). In dev and prod, I think `turbomodule/core/jni:jni` was pulling in `fbjni` from its `react_native_target("jni/react/jni:jni")` dependency even though `FBJNI_TARGET` wasn't an exported_dep of `react_native_target("jni/react/jni:jni")`. In `android_automation_cameracore_release_build`, however, this wasn't happening, which led to that build failing to compile.

In this diff, I'm explicitly making `FBJNI_TARGET` a dependency of `fbsource//xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni:jni`. This unbreaks `android_automation_cameracore_release_build`.

Reviewed By: fkgozali

Differential Revision: D15758160

fbshipit-source-id: db20c127a888b0cf68aea592de6a2e380c455c1d
This commit is contained in:
Ramanpreet Nara
2019-06-11 10:15:17 -07:00
committed by Facebook Github Bot
parent 36307d87e1
commit 9cea76072a
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/BUCK
+1
View File
@@ -28,6 +28,7 @@ rn_xplat_cxx_library(
],
deps = [
react_native_target("jni/react/jni:jni"),
FBJNI_TARGET,
],
exported_deps = [
"fbsource//xplat/jsi:jsi",