From 9cea76072a6d0faab039c01700d6a9c893dda279 Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Tue, 11 Jun 2019 10:10:06 -0700 Subject: [PATCH] Make turbomodule/core/jni:jni depend on FBJNI_TARGET Summary: `fbsource//xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni:jni` is a shared library that depends on `fbjni` (also another shared library). In dev and prod, I think `turbomodule/core/jni:jni` was pulling in `fbjni` from its `react_native_target("jni/react/jni:jni")` dependency even though `FBJNI_TARGET` wasn't an exported_dep of `react_native_target("jni/react/jni:jni")`. In `android_automation_cameracore_release_build`, however, this wasn't happening, which led to that build failing to compile. In this diff, I'm explicitly making `FBJNI_TARGET` a dependency of `fbsource//xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni:jni`. This unbreaks `android_automation_cameracore_release_build`. Reviewed By: fkgozali Differential Revision: D15758160 fbshipit-source-id: db20c127a888b0cf68aea592de6a2e380c455c1d --- .../src/main/java/com/facebook/react/turbomodule/core/jni/BUCK | 1 + 1 file changed, 1 insertion(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/BUCK b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/BUCK index b2a7e529a72..cf7f36a1c06 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/BUCK @@ -28,6 +28,7 @@ rn_xplat_cxx_library( ], deps = [ react_native_target("jni/react/jni:jni"), + FBJNI_TARGET, ], exported_deps = [ "fbsource//xplat/jsi:jsi",