mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Use RN Build Utils for Building Hermes Artifacts
Summary: We moved Hermes some build utils from [Hermes repo](https://github.com/facebook/hermes/tree/main/utils) to [React Navtie repo](https://github.com/facebook/react-native/tree/main/sdks/hermes-engine/utils) a while ago to have more control over them. However some paths on the CI were not updated. We continued to use old build scripts for Hermes prebuilds. Some unfortunate side effects are: - `HERMES_ENABLE_DEBUGGER` is [hardcoded to true](https://github.com/facebook/hermes/blob/main/utils/build-apple-framework.sh#L65). That makes Hermes much slower in Release configuration. - BUILD_TYPE is [set to Release](https://github.com/facebook/hermes/blob/main/utils/build-apple-framework.sh#L10) instead of `MinSizeRel` which inreases Hermes binary size. This diff copies these build utils from RN to Hermes source directory before we perform Hermes build. Changelog [Internal] Reviewed By: cipolleschi Differential Revision: D44066721 fbshipit-source-id: f45ad6a31fb01c10199f69cc7bbcbbc83b793d34
This commit is contained in:
committed by
Lorenzo Sciandra
parent
256e25c792
commit
9be29593c8
@@ -1244,6 +1244,7 @@ jobs:
|
||||
command: |
|
||||
mkdir -p $HERMES_OSXBIN_ARTIFACTS_DIR ./sdks/hermes
|
||||
cp -r $HERMES_WS_DIR/hermes/* ./sdks/hermes/.
|
||||
cp -r ./sdks/hermes-engine/utils ./sdks/hermes/.
|
||||
- brew_install:
|
||||
package: cmake
|
||||
- with_hermes_tarball_cache_span:
|
||||
|
||||
Reference in New Issue
Block a user