mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Avoid spawning a new iOS simulator if one is already booted (#55931)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/55931 Changelog: [Internal] Previously, `testRNTesterIOS` would either unconditionally boot a new simulator (local build path) or check only for an exact "iPhone 16 Pro" match (CI artifacts path). This caused a new iOS simulator to always spawn even when one was already open. Extracted a `bootSimulatorIfNeeded` helper that checks for any booted simulator via `xcrun simctl list devices booted` before attempting to boot a new one. Reviewed By: cipolleschi Differential Revision: D95368633 fbshipit-source-id: 858bd235486597b5c9dbb0b904fcd95707b92b13
This commit is contained in:
1 parent
8c763fcce2
commit
977ad71cab
1 file changed
+16
-10
@@ -102,14 +102,7 @@ async function testRNTesterIOS(
|
||||
exec(`unzip ${hermesAppZipPath} -d ${appOutputFolder}`);
|
||||
|
||||
// boot device
|
||||
const bootedDevice = String(
|
||||
exec('xcrun simctl list | grep "iPhone 16 Pro" | grep Booted', {
|
||||
silent: true,
|
||||
}),
|
||||
).trim();
|
||||
if (!bootedDevice || bootedDevice.length === 0) {
|
||||
exec('xcrun simctl boot "iPhone 16 Pro"');
|
||||
}
|
||||
bootSimulatorIfNeeded();
|
||||
|
||||
// install app on device
|
||||
exec(`xcrun simctl install booted ${appOutputFolder}`);
|
||||
@@ -118,12 +111,13 @@ async function testRNTesterIOS(
|
||||
`USE_HERMES=1 CI=${onReleaseBranch.toString()} RCT_NEW_ARCH_ENABLED=1 bundle exec pod install --ansi`,
|
||||
);
|
||||
|
||||
// boot device
|
||||
bootSimulatorIfNeeded();
|
||||
|
||||
// build the app on iOS simulator
|
||||
exec(
|
||||
'xcodebuild -workspace RNTesterPods.xcworkspace -scheme RNTester -sdk "iphonesimulator" -destination "generic/platform=iOS Simulator" -derivedDataPath "/tmp/RNTesterBuild"',
|
||||
);
|
||||
// boot device
|
||||
exec('xcrun simctl boot "iPhone 16 Pro"');
|
||||
// install app on device
|
||||
exec(
|
||||
'xcrun simctl install booted "/tmp/RNTesterBuild/Build/Products/Debug-iphonesimulator/RNTester.app"',
|
||||
@@ -324,6 +318,18 @@ async function testRNTestProject(
|
||||
popd();
|
||||
}
|
||||
|
||||
function bootSimulatorIfNeeded() {
|
||||
const bootedDevices = String(
|
||||
exec('xcrun simctl list devices booted', {silent: true}),
|
||||
).trim();
|
||||
// Check if there is at least one booted device by looking for a line with a UDID
|
||||
if (/\([A-F0-9-]+\)/i.test(bootedDevices)) {
|
||||
console.info('An iOS simulator is already booted, skipping boot.');
|
||||
return;
|
||||
}
|
||||
exec('xcrun simctl boot "iPhone 16 Pro"');
|
||||
}
|
||||
|
||||
async function main() {
|
||||
/*
|
||||
* see the test-local-e2e.js script for clean up process
|
||||
|
||||
Reference in new issue
Block a user