Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Trigger garbage collection when the app receive memory warning

Browse Source 
Summary:
Changelog: [internal]

The condition inside `[RCTCxxBridge handleMemoryWarning]` was preventing JS VM from handling memory pressure if React Native was loading. This seems incorrect as loading only occurs once at the startup but memory pressure event occurs mostly after React Native was initialised. Therefore, JS VM wasn't handling memory pressure events.

Reviewed By: shergin

Differential Revision: D24646724

fbshipit-source-id: 7b4420fe675261e434c3427c8ad366ba0086a453
This commit is contained in:
Samuel Susla
2020-10-30 08:16:58 -07:00
committed by Facebook GitHub Bot
parent be8fe21d06
commit 96ecad4341
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/CxxBridge/RCTCxxBridge.mm
+3 -1
View File
@@ -310,7 +310,9 @@ struct RCTInstanceCallback : public InstanceCallback {
- (void)handleMemoryWarning
{
if (!_valid || !_loading) {
// We only want to run garbage collector when the loading is finished
// and the instance is valid.
if (!_valid || _loading) {
return;
}