Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove __fbRequireBatchedBridge call when not get batchedBridge (#23547)

Browse Source 
Summary:
From the git log, we added `__fbRequireBatchedBridge` in this commit  https://github.com/facebook/react-native/commit/6dc3a83e88ed120decbeaed8e4e62dc2bb7107a3, I don't ensure wether I missed something, we actually don't define `__fbRequireBatchedBridge` on `JS` or `Native` side, so `__fbRequireBatchedBridge` getter operation itself would throw exception.

[General] [Fixed] - Remove __fbRequireBatchedBridge call when not get batchedBridge
Pull Request resolved: https://github.com/facebook/react-native/pull/23547

Differential Revision: D14160706

Pulled By: cpojer

fbshipit-source-id: df9180a9a16716a91369249333752316fb6648c5
This commit is contained in:
zhongwuzw
2019-02-20 18:41:24 -08:00
committed by Facebook Github Bot
parent 104b1f9367
commit 96de12ab48
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp
+2 -7
View File
@@ -285,13 +285,8 @@ void JSIExecutor::bindBridge() {
Value batchedBridgeValue =
runtime_->global().getProperty(*runtime_, "__fbBatchedBridge");
if (batchedBridgeValue.isUndefined()) {
Function requireBatchedBridge = runtime_->global().getPropertyAsFunction(
*runtime_, "__fbRequireBatchedBridge");
batchedBridgeValue = requireBatchedBridge.call(*runtime_);
if (batchedBridgeValue.isUndefined()) {
throw JSINativeException(
"Could not get BatchedBridge, make sure your bundle is packaged correctly");
}
throw JSINativeException(
"Could not get BatchedBridge, make sure your bundle is packaged correctly");
}
Object batchedBridge = batchedBridgeValue.asObject(*runtime_);