Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop WITH_INSPECTOR build flag (#41911)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41911

Follow-up to D52040150.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D52072475

fbshipit-source-id: d028ca4c5282c4c061af08be5d7e63f1c3d9bdcb
This commit is contained in:
Alex Hunt
2023-12-13 03:37:32 -08:00
committed by Facebook GitHub Bot
parent 4fcfde1114
commit 957a1977b3
5 changed files with 3 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake
-1
View File
@@ -58,7 +58,6 @@ target_compile_options(${CMAKE_PROJECT_NAME}
-fexceptions
-frtti
-std=c++20
-DWITH_INSPECTOR=1
-DLOG_TAG=\"ReactNative\")
# Prefab packages from React Native
packages/react-native/ReactAndroid/src/main/jni/react/jni/CMakeLists.txt
+1 -2
View File
@@ -11,8 +11,7 @@ file(GLOB reactnativejni_SRC CONFIGURE_DEPENDS *.cpp)
add_compile_options(
-fexceptions
-Wno-unused-lambda-capture
-std=c++20
-DWITH_INSPECTOR=1)
-std=c++20)
######################
### reactnativejni ###
packages/react-native/ReactAndroid/src/main/jni/react/jni/JInspector.cpp
-4
View File
@@ -9,8 +9,6 @@
#include <memory>
#ifdef WITH_INSPECTOR
namespace facebook::react {
namespace {
@@ -111,5 +109,3 @@ void JInspector::registerNatives() {
}
} // namespace facebook::react
#endif
packages/react-native/ReactAndroid/src/main/jni/react/jni/JInspector.h
-4
View File
@@ -7,8 +7,6 @@
#pragma once
#ifdef WITH_INSPECTOR
#include <jsinspector-modern/InspectorInterfaces.h>
#include <fbjni/fbjni.h>
@@ -77,5 +75,3 @@ class JInspector : public jni::HybridClass<JInspector> {
};
} // namespace facebook::react
#endif
packages/react-native/ReactAndroid/src/main/jni/react/jni/OnLoad.cpp
+2 -8
View File
@@ -16,17 +16,14 @@
#include "CatalystInstanceImpl.h"
#include "CxxModuleWrapperBase.h"
#include "JCallback.h"
#include "JInspector.h"
#include "JInspectorFlags.h"
#include "JReactMarker.h"
#include "JavaScriptExecutorHolder.h"
#include "ProxyExecutor.h"
#include "WritableNativeArray.h"
#include "WritableNativeMap.h"
#ifdef WITH_INSPECTOR
#include "JInspector.h"
#include "JInspectorFlags.h"
#endif
#ifndef WITH_GLOGINIT
#define WITH_GLOGINIT 1
#endif
@@ -87,11 +84,8 @@ extern "C" JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
ReadableNativeMap::registerNatives();
WritableNativeMap::registerNatives();
JReactMarker::registerNatives();
#ifdef WITH_INSPECTOR
JInspector::registerNatives();
JInspectorFlags::registerNatives();
#endif
});
}