Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update 'cannot calculate shadow efficiently' log message (#39700)

Browse Source 
Summary:
While working in an app I kept getting these `View X of type Y has a shadow set but cannot calculate shadow efficiently. Consider setting a background color to fix this` warnings even though I had added a background color to that view. Upon inspecting RCTView.m I notice that what is actually required to fix this is a solid background

To make this a bit clearer to developers I believe we should update this log message to explicitly say "solid background" instead of "background"

## Changelog:

[IOS] [CHANGED] - Update 'cannot calculate shadow efficiently' log message to explicitly say solid background

Pull Request resolved: https://github.com/facebook/react-native/pull/39700

Test Plan: N / A

Reviewed By: christophpurrer

Differential Revision: D51584574

Pulled By: javache

fbshipit-source-id: b1741f7002ebb876e4a50959bef7f39df76a5c3c
This commit is contained in:
Gabriel Donadel
2023-11-28 03:24:25 -08:00
committed by Facebook GitHub Bot
parent 9078db77a9
commit 94c7661206
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/React/Views/RCTView.m
+1 -1
View File
@@ -883,7 +883,7 @@ static void RCTUpdateShadowPathForView(RCTView *view)
RCTLogAdvice(
@"View #%@ of type %@ has a shadow set but cannot calculate "
"shadow efficiently. Consider setting a background color to "
"shadow efficiently. Consider setting a solid background color to "
"fix this, or apply the shadow to a more specific component.",
view.reactTag,
[view class]);