Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use RCTModernEventEmitter in EventAnimationDriver (#42388)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/42388

This was our last call site still using the legacy `dispatch` API.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D52906894

fbshipit-source-id: b1c838ee695ce4c60aaed409e7dc46a0dd3f6c2e
This commit is contained in:
Pieter De Baets
2024-01-22 08:20:54 -08:00
committed by Facebook GitHub Bot
parent 6d77d7b895
commit 94c72d5916
2 changed files with 38 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/EventAnimationDriver.java
+37 -9
View File
@@ -14,11 +14,13 @@ import com.facebook.react.bridge.ReadableType;
import com.facebook.react.bridge.UnexpectedNativeTypeException;
import com.facebook.react.bridge.WritableArray;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.uimanager.events.RCTEventEmitter;
import com.facebook.react.uimanager.events.EventCategoryDef;
import com.facebook.react.uimanager.events.RCTModernEventEmitter;
import com.facebook.react.uimanager.events.TouchEvent;
import java.util.List;
/** Handles updating a {@link ValueAnimatedNode} when an event gets dispatched. */
/* package */ class EventAnimationDriver implements RCTEventEmitter {
/* package */ class EventAnimationDriver implements RCTModernEventEmitter {
private List<String> mEventPath;
/* package */ ValueAnimatedNode mValueNode;
/* package */ String mEventName;
@@ -33,7 +35,39 @@ import java.util.List;
}
@Override
public void receiveEvent(int targetTag, String eventName, @Nullable WritableMap event) {
public void receiveEvent(int targetReactTag, String eventName, @Nullable WritableMap event) {
receiveEvent(-1, targetReactTag, eventName, event);
}
@Override
public void receiveEvent(
int surfaceId, int targetTag, String eventName, @Nullable WritableMap event) {
// We assume this event can't be coalesced. `customCoalesceKey` has no meaning in Fabric.
receiveEvent(surfaceId, targetTag, eventName, false, 0, event, EventCategoryDef.UNSPECIFIED);
}
@Override
public void receiveTouches(
String eventName, WritableArray touches, WritableArray changedIndices) {
throw new UnsupportedOperationException(
"receiveTouches is not support by native animated events");
}
@Override
public void receiveTouches(TouchEvent touchEvent) {
throw new UnsupportedOperationException(
"receiveTouches is not support by native animated events");
}
@Override
public void receiveEvent(
int surfaceId,
int targetTag,
String eventName,
boolean canCoalesceEvent,
int customCoalesceKey,
@Nullable WritableMap event,
@EventCategoryDef int category) {
if (event == null) {
throw new IllegalArgumentException("Native animated events must have event data.");
}
@@ -79,10 +113,4 @@ import java.util.List;
mValueNode.mValue = currArray.getDouble(lastIndex);
}
}
@Override
public void receiveTouches(
String eventName, WritableArray touches, WritableArray changedIndices) {
throw new RuntimeException("receiveTouches is not support by native animated events");
}
}
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java
+1 -1
View File
@@ -603,7 +603,7 @@ public class NativeAnimatedNodesManager implements EventDispatcherListener {
if (matchSpec.match(driver.mViewTag, driver.mEventName)) {
foundAtLeastOneDriver = true;
stopAnimationsForNode(driver.mValueNode);
event.dispatch(driver);
event.dispatchModern(driver);
mRunUpdateNodeList.add(driver.mValueNode);
}
}