Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

community-cli-plugin: Use TerminalReporter type from metro, replace deep imports (#51092)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/51092

`TerminalReporter` is re-exported from `metro` (since [0.76.7](https://github.com/facebook/metro/releases/tag/v0.76.7)), so we can update these deep imports to use public exports.

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D74141704

fbshipit-source-id: 22cd3209868ed9ab260e199f9099ef98335feaeb
This commit is contained in:
Rob Hogan
2025-05-04 09:57:57 -07:00
committed by Facebook GitHub Bot
parent 5eed872463
commit 93f22e79d4
5 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/community-cli-plugin/src/commands/start/OpenDebuggerKeyboardHandler.js
+1 -1
View File
@@ -9,7 +9,7 @@
* @oncall react_native
*/
import type TerminalReporter from 'metro/src/lib/TerminalReporter';
import type {TerminalReporter} from 'metro';
import chalk from 'chalk';
packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js
+1 -1
View File
@@ -9,7 +9,7 @@
* @oncall react_native
*/
import type TerminalReporter from 'metro/src/lib/TerminalReporter';
import type {TerminalReporter} from 'metro';
import OpenDebuggerKeyboardHandler from './OpenDebuggerKeyboardHandler';
import chalk from 'chalk';
packages/community-cli-plugin/src/commands/start/runServer.js
+4 -2
View File
@@ -10,9 +10,9 @@
*/
import type {Config} from '@react-native-community/cli-types';
import type {TerminalReporter} from 'metro';
import type {Reporter} from 'metro/src/lib/reporting';
import type {TerminalReportableEvent} from 'metro/src/lib/TerminalReporter';
import typeof TerminalReporter from 'metro/src/lib/TerminalReporter';
import createDevMiddlewareLogger from '../../utils/createDevMiddlewareLogger';
import isDevServerRunning from '../../utils/isDevServerRunning';
@@ -176,7 +176,9 @@ async function runServer(
await version.logIfUpdateAvailable(cliConfig, terminalReporter);
}
function getReporterImpl(customLogReporterPath?: string): TerminalReporter {
function getReporterImpl(
customLogReporterPath?: string,
): Class<TerminalReporter> {
if (customLogReporterPath == null) {
return require('metro/src/lib/TerminalReporter');
}
packages/community-cli-plugin/src/utils/createDevMiddlewareLogger.js
+1 -1
View File
@@ -9,7 +9,7 @@
* @oncall react_native
*/
import type TerminalReporter from 'metro/src/lib/TerminalReporter';
import type {TerminalReporter} from 'metro';
type LoggerFn = (...message: $ReadOnlyArray<string>) => void;
packages/community-cli-plugin/src/utils/version.js
+1 -1
View File
@@ -10,7 +10,7 @@
*/
import type {Config} from '@react-native-community/cli-types';
import type TerminalReporter from 'metro/src/lib/TerminalReporter';
import type {TerminalReporter} from 'metro';
import chalk from 'chalk';
import semver from 'semver';