mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Make it so that aspect ratio behaves like auto if it is 0 or inf (#46428)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46428 X-link: https://github.com/facebook/yoga/pull/1696 We do not validate the aspect ratio to ensure it is non zero and non inf in a lot of places. Per the spec, these values should act like auto. There is no auto keyword, but it is the default so I just set the style to a default FloatOptional in this case Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D62473161 fbshipit-source-id: 6857de819538a7a87ce0a652e99f5a49992921ae
This commit is contained in:
1 parent
d7c1e5b989
commit
93b608d130
1 file changed
+5
-1
@@ -199,7 +199,11 @@ class YG_EXPORT Style {
|
||||
return pool_.getNumber(aspectRatio_);
|
||||
}
|
||||
void setAspectRatio(FloatOptional value) {
|
||||
pool_.store(aspectRatio_, value);
|
||||
// degenerate aspect ratios act as auto.
|
||||
// see https://drafts.csswg.org/css-sizing-4/#valdef-aspect-ratio-ratio
|
||||
pool_.store(
|
||||
aspectRatio_,
|
||||
value == 0.0f || std::isinf(value.unwrap()) ? FloatOptional{} : value);
|
||||
}
|
||||
|
||||
bool horizontalInsetsDefined() const {
|
||||
|
||||
Reference in new issue
Block a user