mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fixed build type when downloading hermes artifacts (#51283)
Summary: Hermes build-type was hardcoded to 'release' in the previous version of the prebuild scripts. This commit fixes this so that we can provide a build-type for hermes when downloading prebuilt tarballs. - Cleaned up parameters in hermes.js - Updated with buildType parameter when suitable - Fixed some function names - Updated version file so that it contains build type - Removed version file when using a local tarball ## Changelog: [IOS] [FIXED] - Fixed resolving build type when downloading hermes artifacts Pull Request resolved: https://github.com/facebook/react-native/pull/51283 Test Plan: No test-plan yet Reviewed By: cortinico Differential Revision: D74882001 Pulled By: cipolleschi fbshipit-source-id: cfeed934023712e70f7d04c137e8611164120cec
This commit is contained in:
committed by
Facebook GitHub Bot
parent
e2f6ce4ddf
commit
9371e20192
+1
-1
@@ -109,7 +109,7 @@ async function main() {
|
||||
};
|
||||
|
||||
// HERMES ARTIFACTS
|
||||
await prepareHermesArtifactsAsync(currentVersion, 'release');
|
||||
await prepareHermesArtifactsAsync(currentVersion, 'debug');
|
||||
|
||||
// CODEGEN
|
||||
const codegenPath = path.join(root, '.build/codegen');
|
||||
|
||||
Reference in New Issue
Block a user