Implement prop diffing for basic props in <View> (#48829)

Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48829 This diff implements the diffing for basic props of <View> changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59972040 fbshipit-source-id: 148b5fc9b73887c153535648182386d75bf9381b
2025-11-01 09:14:26 +00:00 · 2025-01-22 12:07:06 -08:00
parent 5ee2289298
commit 92d79461e9
1 changed files with 106 additions and 0 deletions
@@ -145,10 +145,116 @@ folly::dynamic HostPlatformViewProps::getDiffProps(
      ? &defaultProps
      : static_cast<const HostPlatformViewProps*>(prevProps);

+  if (this == oldProps) {
+    return result;
+  }
  if (focusable != oldProps->focusable) {
    result["focusable"] = focusable;
  }

+  if (hasTVPreferredFocus != oldProps->hasTVPreferredFocus) {
+    result["hasTVPreferredFocus"] = hasTVPreferredFocus;
+  }
+
+  if (needsOffscreenAlphaCompositing !=
+      oldProps->needsOffscreenAlphaCompositing) {
+    result["needsOffscreenAlphaCompositing"] = needsOffscreenAlphaCompositing;
+  }
+
+  if (renderToHardwareTextureAndroid !=
+      oldProps->renderToHardwareTextureAndroid) {
+    result["renderToHardwareTextureAndroid"] = renderToHardwareTextureAndroid;
+  }
+
+  if (opacity != oldProps->opacity) {
+    result["opacity"] = opacity;
+  }
+
+  if (backgroundColor != oldProps->backgroundColor) {
+    result["backgroundColor"] = *backgroundColor;
+  }
+
+  if (shadowColor != oldProps->shadowColor) {
+    result["shadowColor"] = *shadowColor;
+  }
+
+  if (shadowOpacity != oldProps->shadowOpacity) {
+    result["shadowOpacity"] = shadowOpacity;
+  }
+
+  if (shadowRadius != oldProps->shadowRadius) {
+    result["shadowRadius"] = shadowRadius;
+  }
+
+  if (shouldRasterize != oldProps->shouldRasterize) {
+    result["shouldRasterize"] = shouldRasterize;
+  }
+
+  if (collapsable != oldProps->collapsable) {
+    result["collapsable"] = collapsable;
+  }
+
+  if (removeClippedSubviews != oldProps->removeClippedSubviews) {
+    result["removeClippedSubviews"] = removeClippedSubviews;
+  }
+
+  if (onLayout != oldProps->onLayout) {
+    result["onLayout"] = onLayout;
+  }
+
+  if (zIndex != oldProps->zIndex) {
+    result["zIndex"] = zIndex.value();
+  }
+
+  if (pointerEvents != oldProps->pointerEvents) {
+    std::string value;
+    switch (pointerEvents) {
+      case PointerEventsMode::BoxOnly:
+        result["pointerEvents"] = "box-only";
+        break;
+      case PointerEventsMode::BoxNone:
+        result["pointerEvents"] = "box-none";
+        break;
+      case PointerEventsMode::None:
+        result["pointerEvents"] = "none";
+        break;
+      default:
+        result["pointerEvents"] = "auto";
+        break;
+    }
+
+    if (nativeId != oldProps->nativeId) {
+      result["nativeId"] = nativeId;
+    }
+
+    if (testId != oldProps->testId) {
+      result["testId"] = testId;
+    }
+
+    if (accessible != oldProps->accessible) {
+      result["accessible"] = accessible;
+    }
+
+    if (getClipsContentToBounds() != oldProps->getClipsContentToBounds()) {
+      result["overflow"] = getClipsContentToBounds() ? "hidden" : "visible";
+      result["scroll"] = result["overflow"];
+    }
+
+    if (backfaceVisibility != oldProps->backfaceVisibility) {
+      switch (backfaceVisibility) {
+        case BackfaceVisibility::Auto:
+          result["backfaceVisibility"] = "auto";
+          break;
+        case BackfaceVisibility::Visible:
+          result["backfaceVisibility"] = "visible";
+          break;
+        case BackfaceVisibility::Hidden:
+          result["backfaceVisibility"] = "hidden";
+          break;
+      }
+    }
+  }
+
  return result;
 }