Fix lints

Summary:
Fixing lint warningns and errors found during analysis

bypass-github-export-checks

changelog: [internal] internal

Reviewed By: rshest

Differential Revision: D51262579

fbshipit-source-id: 3644b07cd7504c012826faa98249958062366534

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/MemoryPressureRouter.java

@@ -18,7 +18,7 @@ import java.util.Set;
 /** Translates and routes memory pressure events to the current catalyst instance. */
 public class MemoryPressureRouter implements ComponentCallbacks2 {
   private final Set<MemoryPressureListener> mListeners =
-      Collections.synchronizedSet(new LinkedHashSet<MemoryPressureListener>());
+      Collections.synchronizedSet(new LinkedHashSet<>());
 
   public MemoryPressureRouter(Context context) {
     context.getApplicationContext().registerComponentCallbacks(this);

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/NativeModuleRegistryBuilder.java

@@ -17,14 +17,12 @@ import java.util.Map;
 public class NativeModuleRegistryBuilder {
 
   private final ReactApplicationContext mReactApplicationContext;
-  private final ReactInstanceManager mReactInstanceManager;
 
   private final Map<String, ModuleHolder> mModules = new HashMap<>();
 
   public NativeModuleRegistryBuilder(
       ReactApplicationContext reactApplicationContext, ReactInstanceManager reactInstanceManager) {
     mReactApplicationContext = reactApplicationContext;
-    mReactInstanceManager = reactInstanceManager;
   }
 
   public void processPackage(ReactPackage reactPackage) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivity.java

@@ -16,6 +16,7 @@ import androidx.appcompat.app.AppCompatActivity;
 import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
 import com.facebook.react.modules.core.PermissionAwareActivity;
 import com.facebook.react.modules.core.PermissionListener;
+import org.jetbrains.annotations.NotNull;
 
 /** Base Activity for React Native applications. */
 public abstract class ReactActivity extends AppCompatActivity
@@ -112,7 +113,7 @@ public abstract class ReactActivity extends AppCompatActivity
 
   @Override
   public void onRequestPermissionsResult(
-      int requestCode, String[] permissions, int[] grantResults) {
+      int requestCode, @NotNull String[] permissions, @NotNull int[] grantResults) {
     mDelegate.onRequestPermissionsResult(requestCode, permissions, grantResults);
   }
 
@@ -123,7 +124,7 @@ public abstract class ReactActivity extends AppCompatActivity
   }
 
   @Override
-  public void onConfigurationChanged(Configuration newConfig) {
+  public void onConfigurationChanged(@NotNull Configuration newConfig) {
     super.onConfigurationChanged(newConfig);
     mDelegate.onConfigurationChanged(newConfig);
   }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java

@@ -34,12 +34,13 @@ public class ReactActivityDelegate {
   private ReactDelegate mReactDelegate;
 
   @Deprecated
-  public ReactActivityDelegate(Activity activity, @Nullable String mainComponentName) {
+  public ReactActivityDelegate(@Nullable Activity activity, @Nullable String mainComponentName) {
     mActivity = activity;
     mMainComponentName = mainComponentName;
   }
 
-  public ReactActivityDelegate(ReactActivity activity, @Nullable String mainComponentName) {
+  public ReactActivityDelegate(
+      @Nullable ReactActivity activity, @Nullable String mainComponentName) {
     mActivity = activity;
     mMainComponentName = mainComponentName;
   }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell/MainPackageConfig.java

@@ -12,7 +12,7 @@ import com.facebook.imagepipeline.core.ImagePipelineConfig;
 /** Configuration for {@link MainReactPackage} */
 public class MainPackageConfig {
 
-  private ImagePipelineConfig mFrescoConfig;
+  private final ImagePipelineConfig mFrescoConfig;
 
   private MainPackageConfig(Builder builder) {
     mFrescoConfig = builder.mFrescoConfig;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/util/ReactFindViewUtil.java

@@ -115,12 +115,11 @@ public class ReactFindViewUtil {
     Iterator<OnViewFoundListener> iterator = mOnViewFoundListeners.iterator();
     while (iterator.hasNext()) {
       OnViewFoundListener listener = iterator.next();
-      if (nativeId != null && nativeId.equals(listener.getNativeId())) {
+      if (nativeId.equals(listener.getNativeId())) {
         listener.onViewFound(view);
         iterator.remove();
       }
     }
-
     for (Map.Entry<OnMultipleViewsFoundListener, Set<String>> entry :
         mOnMultipleViewsFoundListener.entrySet()) {
       Set<String> nativeIds = entry.getValue();