mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fix: iOS crash occurring when navigating to a new app screen with a displaying modal (#45313)
Summary: Our app is using the react-native v0.74.2 with the `react-navigation` lib for screen navigation, we're facing an issue in the built iOS app that when we try to navigate to a new app screen with the `react-navigation`'s `reset` or `replace` method and meanwhile there's a react native modal displaying, then the iOS app always crashes. I saw there is already a relevant [PR](https://github.com/facebook/react-native/pull/38491) and discussion targeting this issue, but I still think it would be better if this kind of crash can be suppressed in the framework level, currently I guess it's common in the iOS apps based on react native. ## Changelog: [IOS] [FIXED] - app crash happening when navigate to a new app screen with a displaying modal Pull Request resolved: https://github.com/facebook/react-native/pull/45313 Test Plan: More issue details and the reproduction steps can be found in this [PR](https://github.com/facebook/react-native/pull/38491) :) Reviewed By: christophpurrer Differential Revision: D61537167 Pulled By: cipolleschi fbshipit-source-id: 3c0474d794b4216ebc073dd6558d2b6ae27492d2
This commit is contained in:
@@ -119,6 +119,7 @@ RCT_NOT_IMPLEMENTED(-(instancetype)initWithCoder : coder)
|
||||
if (_isPresented) {
|
||||
[_delegate dismissModalHostView:self withViewController:_modalViewController animated:[self hasAnimationType]];
|
||||
_isPresented = NO;
|
||||
[self setVisible:NO];
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user