Fix LogBoxSymbolication-test.js

Summary:
This test was causing uncaught promise rejections, because the mocked `symbolicateStackTrace` in this test returns a different type from the real one, causing `LogBoxSymbolication`'s unawaited, cached promises to reject.

This wasn't picked up as a test failure because our `promise` polyfill silently swallows uncaught rejections, but it does cause a failure if we use native promises in tests.

Changelog:
[Internal][Fixed] - Fix LogBoxSymbolication-test.js

Reviewed By: huntie

Differential Revision: D39418412

fbshipit-source-id: 0be8f1551c4a58dc47faf1597caf47271af40af2
This commit is contained in:
Rob Hogan
2022-09-12 03:57:45 -07:00
committed by Facebook GitHub Bot
parent f1c1f8116b
commit 8e0168fe9d
@@ -12,6 +12,7 @@
'use strict';
import type {StackFrame} from '../../../Core/NativeExceptionsManager';
import type {SymbolicatedStackTrace} from '../../../Core/Devtools/symbolicateStackTrace';
jest.mock('../../../Core/Devtools/symbolicateStackTrace');
@@ -19,7 +20,7 @@ const LogBoxSymbolication = require('../LogBoxSymbolication');
const symbolicateStackTrace: JestMockFn<
$ReadOnlyArray<Array<StackFrame>>,
Promise<Array<StackFrame>>,
Promise<SymbolicatedStackTrace>,
> = (require('../../../Core/Devtools/symbolicateStackTrace'): any);
const createStack = (methodNames: Array<string>) =>
@@ -33,7 +34,10 @@ const createStack = (methodNames: Array<string>) =>
describe('LogBoxSymbolication', () => {
beforeEach(() => {
jest.resetModules();
symbolicateStackTrace.mockImplementation(async stack => stack);
symbolicateStackTrace.mockImplementation(async stack => ({
stack,
codeFrame: null,
}));
});
it('symbolicates different stacks', () => {