Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Maps instead of Objects for MessageQueue callbacks

Browse Source 
Summary:
This lead to exceeding the Object property count limit in Hermes:
```
Unhandled JS Exception: Property storage can't accommodate 254464 properties, js engine: hermes
```

Reviewed By: PeteTheHeat

Differential Revision: D16212572

fbshipit-source-id: 8fcedb55ebd1f8b289ec759ea1ad4e81cf903dfd
This commit is contained in:
Spencer Ahrens
2019-07-17 14:15:54 -07:00
committed by Facebook Github Bot
parent 87e02702a9
commit 8dcee62be9
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/BatchedBridge/MessageQueue.js
+10 -10
View File
@@ -40,8 +40,8 @@ const DEBUG_INFO_LIMIT = 32;
class MessageQueue {
_lazyCallableModules: {[key: string]: (void) => Object};
_queue: [number[], number[], any[], number];
_successCallbacks: {[key: number]: ?Function};
_failureCallbacks: {[key: number]: ?Function};
_successCallbacks: Map<number, ?Function>;
_failureCallbacks: Map<number, ?Function>;
_callID: number;
_lastFlush: number;
_eventLoopStartTime: number;
@@ -56,8 +56,8 @@ class MessageQueue {
constructor() {
this._lazyCallableModules = {};
this._queue = [[], [], [], 0];
this._successCallbacks = {};
this._failureCallbacks = {};
this._successCallbacks = new Map();
this._failureCallbacks = new Map();
this._callID = 0;
this._lastFlush = 0;
this._eventLoopStartTime = Date.now();
@@ -217,8 +217,8 @@ class MessageQueue {
onFail && params.push(this._callID << 1);
// eslint-disable-next-line no-bitwise
onSucc && params.push((this._callID << 1) | 1);
this._successCallbacks[this._callID] = onSucc;
this._failureCallbacks[this._callID] = onFail;
this._successCallbacks.set(this._callID, onSucc);
this._failureCallbacks.set(this._callID, onFail);
}
if (__DEV__) {
global.nativeTraceBeginAsyncFlow &&
@@ -423,8 +423,8 @@ class MessageQueue {
// eslint-disable-next-line no-bitwise
const isSuccess = cbID & 1;
const callback = isSuccess
? this._successCallbacks[callID]
: this._failureCallbacks[callID];
? this._successCallbacks.get(callID)
: this._failureCallbacks.get(callID);
if (__DEV__) {
const debug = this._debugInfo[callID];
@@ -453,8 +453,8 @@ class MessageQueue {
return;
}
delete this._successCallbacks[callID];
delete this._failureCallbacks[callID];
this._successCallbacks.delete(callID);
this._failureCallbacks.delete(callID);
callback(...args);
if (__DEV__) {