mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Add missing VIEW_EVENT_CASE entries for W3C Pointer Events in BaseViewProps::setProp (#56188)
Summary: Resolves https://github.com/microsoft/react-native-windows/issues/15827 [ViewEvents::Offset](vscode-file://vscode-app/c:/Program%20Files/Windows%20Development/Microsoft%20VS%20Code/07ff9d6178/resources/app/out/vs/code/electron-browser/workbench/workbench.html) defines enum values for [Click](vscode-file://vscode-app/c:/Program%20Files/Windows%20Development/Microsoft%20VS%20Code/07ff9d6178/resources/app/out/vs/code/electron-browser/workbench/workbench.html), [ClickCapture](vscode-file://vscode-app/c:/Program%20Files/Windows%20Development/Microsoft%20VS%20Code/07ff9d6178/resources/app/out/vs/code/electron-browser/workbench/workbench.html), [PointerDown](vscode-file://vscode-app/c:/Program%20Files/Windows%20Development/Microsoft%20VS%20Code/07ff9d6178/resources/app/out/vs/code/electron-browser/workbench/workbench.html), [PointerDownCapture](vscode-file://vscode-app/c:/Program%20Files/Windows%20Development/Microsoft%20VS%20Code/07ff9d6178/resources/app/out/vs/code/electron-browser/workbench/workbench.html), [PointerUp](vscode-file://vscode-app/c:/Program%20Files/Windows%20Development/Microsoft%20VS%20Code/07ff9d6178/resources/app/out/vs/code/electron-browser/workbench/workbench.html), [PointerUpCapture](vscode-file://vscode-app/c:/Program%20Files/Windows%20Development/Microsoft%20VS%20Code/07ff9d6178/resources/app/out/vs/code/electron-browser/workbench/workbench.html), [GotPointerCapture](vscode-file://vscode-app/c:/Program%20Files/Windows%20Development/Microsoft%20VS%20Code/07ff9d6178/resources/app/out/vs/code/electron-browser/workbench/workbench.html), and [LostPointerCapture](vscode-file://vscode-app/c:/Program%20Files/Windows%20Development/Microsoft%20VS%20Code/07ff9d6178/resources/app/out/vs/code/electron-browser/workbench/workbench.html) (offsets 30–37), but BaseViewProps::setProp() has no corresponding VIEW_EVENT_CASE entries for them. This means when enableCppPropsIteratorSetter() is enabled, these event props (onPointerDown, onPointerUp, onClick, onGotPointerCapture, onLostPointerCapture, and their capture variants) are never parsed from JS — the bits in [ViewEvents](vscode-file://vscode-app/c:/Program%20Files/Windows%20Development/Microsoft%20VS%20Code/07ff9d6178/resources/app/out/vs/code/electron-browser/workbench/workbench.html) are never set, so the native side never knows a component is listening for these events. This PR adds the 8 missing VIEW_EVENT_CASE entries alongside the existing pointer event cases. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [GENERAL][FIXED] - Add missing VIEW_EVENT_CASE entries in BaseViewProps::setProp for Click, PointerDown, PointerUp, GotPointerCapture, LostPointerCapture and their Capture variants (offsets 30-37) Resolves [#15287](https://github.com/microsoft/react-native-windows/issues/15827) For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: https://github.com/facebook/react-native/pull/56188 Reviewed By: christophpurrer Differential Revision: D97732755 Pulled By: javache fbshipit-source-id: 1835f0e62813f146809631f87e4794f0af97db2a
This commit is contained in:
1 parent
5976cff039
commit
8d5482dd94
1 file changed
+8
@@ -442,6 +442,14 @@ void BaseViewProps::setProp(
|
||||
VIEW_EVENT_CASE(PointerOverCapture);
|
||||
VIEW_EVENT_CASE(PointerOut);
|
||||
VIEW_EVENT_CASE(PointerOutCapture);
|
||||
VIEW_EVENT_CASE(Click);
|
||||
VIEW_EVENT_CASE(ClickCapture);
|
||||
VIEW_EVENT_CASE(PointerDown);
|
||||
VIEW_EVENT_CASE(PointerDownCapture);
|
||||
VIEW_EVENT_CASE(PointerUp);
|
||||
VIEW_EVENT_CASE(PointerUpCapture);
|
||||
VIEW_EVENT_CASE(GotPointerCapture);
|
||||
VIEW_EVENT_CASE(LostPointerCapture);
|
||||
VIEW_EVENT_CASE(MoveShouldSetResponder);
|
||||
VIEW_EVENT_CASE(MoveShouldSetResponderCapture);
|
||||
VIEW_EVENT_CASE(StartShouldSetResponder);
|
||||
|
||||
Reference in new issue
Block a user