Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Delete internal ReactPackageLogger as no longer necessary (#53387)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/53387

This interface was internal and legacy arch only, so it can safely be removed.
I've also removed the logic inside `ReactInstanceManager` that was using it as no longer necessary.

Changelog:
[Internal] [Changed] -

Reviewed By: mdvacca

Differential Revision: D80626639

fbshipit-source-id: b173e71b92e29cebbfc5ed589e01ac295eda2bf0
This commit is contained in:
Nicola Corti
2025-08-21 05:31:55 -07:00
committed by Facebook GitHub Bot
parent 4583fbe052
commit 8bdb34732b
3 changed files with 1 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.kt
+1 -9
View File
@@ -66,7 +66,7 @@ internal class CoreModulesPackage(
private val hardwareBackBtnHandler: DefaultHardwareBackBtnHandler,
private val lazyViewManagersEnabled: Boolean,
private val minTimeLeftInFrameForNonBatchedOperationMs: Int,
) : BaseReactPackage(), ReactPackageLogger {
) : BaseReactPackage() {
/**
* This method is overridden, since OSS does not run the annotation processor to generate
* [CoreModulesPackage.ReactModuleInfoProvider] class. Here we check if it exists with the method
@@ -196,14 +196,6 @@ internal class CoreModulesPackage(
}
}
override fun startProcessPackage() {
ReactMarker.logMarker(ReactMarkerConstants.PROCESS_CORE_REACT_PACKAGE_START)
}
override fun endProcessPackage() {
ReactMarker.logMarker(ReactMarkerConstants.PROCESS_CORE_REACT_PACKAGE_END)
}
private companion object {
init {
LegacyArchitectureLogger.assertLegacyArchitecture(
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
-7
View File
@@ -1570,14 +1570,7 @@ public class ReactInstanceManager {
SystraceMessage.beginSection(TRACE_TAG_REACT, "processPackage")
.arg("className", reactPackage.getClass().getSimpleName())
.flush();
if (reactPackage instanceof ReactPackageLogger) {
((ReactPackageLogger) reactPackage).startProcessPackage();
}
nativeModuleRegistryBuilder.processPackage(reactPackage);
if (reactPackage instanceof ReactPackageLogger) {
((ReactPackageLogger) reactPackage).endProcessPackage();
}
SystraceMessage.endSection(TRACE_TAG_REACT).flush();
}
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageLogger.kt
-20
View File
@@ -1,20 +0,0 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
package com.facebook.react
import com.facebook.react.common.annotations.internal.LegacyArchitecture
import com.facebook.react.common.annotations.internal.LegacyArchitectureLogLevel
/** Interface for the bridge to call for TTI start and end markers. */
@Deprecated("This class is deprecated and will be removed in the next major release.")
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
internal interface ReactPackageLogger {
fun startProcessPackage()
fun endProcessPackage()
}