Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update profiler button to use "Toggle" string. (#41900)

Browse Source 
Summary:
Fixes https://github.com/facebook/react-native/issues/38192, this issue wasn't fixed properly, cortinico fixed same case but for inspector button.

## Changelog:

[ANDROID] [FIXED] - Update profiler button to use "Toggle" string.

Pull Request resolved: https://github.com/facebook/react-native/pull/41900

Test Plan: CI

Reviewed By: cortinico

Differential Revision: D52049181

Pulled By: ryancat

fbshipit-source-id: 9225edb3a5a582b879f4ebb835f6ac52cba4c042
This commit is contained in:
szymonrybczak
2023-12-12 03:09:53 -08:00
committed by Facebook GitHub Bot
parent da3ba74240
commit 8bcaed90c1
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/BridgeDevSupportManager.java
+2 -1
View File
@@ -14,6 +14,7 @@ import com.facebook.common.logging.FLog;
import com.facebook.debug.holder.PrinterHolder;
import com.facebook.debug.tags.ReactDebugOverlayTags;
import com.facebook.infer.annotation.Assertions;
import com.facebook.react.R;
import com.facebook.react.bridge.CatalystInstance;
import com.facebook.react.bridge.JSBundleLoader;
import com.facebook.react.bridge.JavaJSExecutor;
@@ -100,7 +101,7 @@ public final class BridgeDevSupportManager extends DevSupportManagerBase {
}
addCustomDevOption(
mIsSamplingProfilerEnabled ? "Disable Sampling Profiler" : "Enable Sampling Profiler",
applicationContext.getString(R.string.catalyst_sample_profiler_toggle),
new DevOptionHandler() {
@Override
public void onOptionSelected() {
packages/react-native/ReactAndroid/src/main/res/devsupport/values/strings.xml
+1 -2
View File
@@ -22,8 +22,7 @@
<string name="catalyst_copy_button" project="catalyst" translatable="false">Copy\n</string>
<string name="catalyst_report_button" project="catalyst" translatable="false">Report</string>
<string name="catalyst_loading_from_url" project="catalyst" translatable="false">Loading from %1$s…</string>
<string name="catalyst_sample_profiler_disable" project="catalyst" translatable="false">Disable Sampling Profiler</string>
<string name="catalyst_sample_profiler_enable" project="catalyst" translatable="false">Enable Sampling Profiler</string>
<string name="catalyst_sample_profiler_toggle" project="catalyst" translatable="false">Toggle Sampling Profiler</string>
<string name="catalyst_dev_menu_header" project="catalyst" translatable="false">React Native Dev Menu (%1$s)</string>
<string name="catalyst_dev_menu_sub_header" project="catalyst" translatable="false">Running %1$s</string>
</resources>