mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Remove unnecessary local variable in for deferred focus (#54326)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/54326 This variable was not needed, isAttachedToWindow was working as expected. ## Changelog [Internal] Reviewed By: Abbondanzo Differential Revision: D85798355 fbshipit-source-id: 1716b323b4ac0d1d6f3e29370223db66540020d2
This commit is contained in:
committed by
meta-codesync[bot]
parent
b68329f7ca
commit
8a3cc6411e
+1
-6
@@ -154,7 +154,6 @@ public open class ReactViewGroup public constructor(context: Context?) :
|
||||
AccessibilityManager.AccessibilityStateChangeListener? =
|
||||
null
|
||||
private var focusOnAttach = false
|
||||
private var hasAttachedToWindowForFocus = false
|
||||
|
||||
init {
|
||||
initView()
|
||||
@@ -217,7 +216,6 @@ public open class ReactViewGroup public constructor(context: Context?) :
|
||||
|
||||
// In case a focus was attempted but the view never attached, reset to false
|
||||
focusOnAttach = false
|
||||
hasAttachedToWindowForFocus = false
|
||||
}
|
||||
|
||||
private var _drawingOrderHelper: ViewGroupDrawingOrderHelper? = null
|
||||
@@ -423,9 +421,7 @@ public open class ReactViewGroup public constructor(context: Context?) :
|
||||
}
|
||||
|
||||
internal fun requestFocusFromJS() {
|
||||
// We need a local variable here as opposed to the View.isAttachedToWindow check
|
||||
// since the value is not updated until after the Fabric commit.
|
||||
if (hasAttachedToWindowForFocus) {
|
||||
if (isAttachedToWindow) {
|
||||
super.requestFocus(FOCUS_DOWN, null)
|
||||
} else {
|
||||
focusOnAttach = true
|
||||
@@ -586,7 +582,6 @@ public open class ReactViewGroup public constructor(context: Context?) :
|
||||
updateClippingRect()
|
||||
}
|
||||
|
||||
hasAttachedToWindowForFocus = true
|
||||
if (focusOnAttach) {
|
||||
requestFocusFromJS()
|
||||
focusOnAttach = false
|
||||
|
||||
Reference in New Issue
Block a user