Facebook/react-native
1
0 Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

LogBox - Better shadow for fatal button

Browse Source 
Summary:
This diff lowers the intensity of the shadow on the fatal button based on user feedback that it's weird.

Changelog: [Internal]

Reviewed By: cpojer

Differential Revision: D18353498

fbshipit-source-id: 9133aae02e5609e181a55289f349ea6a9e9fdaf6
This commit is contained in:
Rick Hanlon authored and Facebook Github Bot committed 2019-11-07 06:32:01 -08:00
1 parent 118e4d2c04
commit 8901a0b863
2 files changed
+52 -34
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

Libraries/LogBox/UI/LogBoxInspectorFooter.js
+4 -1
View File
@@ -29,7 +29,7 @@ type Props = $ReadOnly<{|
function LogBoxInspectorFooter(props: Props): React.Node {
if (props.fatalType === 'fatal' || props.fatalType === 'syntax') {
return (
<View style={styles.root}>
<View style={[styles.root, fatalStyles.root]}>
<LogBoxButton
backgroundColor={{
default: LogBoxStyle.getFatalColor(),
@@ -83,6 +83,9 @@ function FooterButton(props: ButtonProps): React.Node {
}
const fatalStyles = StyleSheet.create({
root: {
shadowColor: LogBoxStyle.getBackgroundDarkColor(1),
},
button: {
flex: 1,
},
Libraries/LogBox/UI/__tests__/__snapshots__/LogBoxInspectorFooter-test.js.snap
+48 -33
View File
@@ -3,18 +3,23 @@
exports[`LogBoxInspectorFooter should render fatal button 1`] = `
<View
style={
Object {
"backgroundColor": "rgba(51, 51, 51, 1)",
"elevation": 1,
"flexDirection": "row",
"shadowColor": "#000",
"shadowOffset": Object {
"height": -2,
"width": 0,
Array [
Object {
"backgroundColor": "rgba(51, 51, 51, 1)",
"elevation": 1,
"flexDirection": "row",
"shadowColor": "#000",
"shadowOffset": Object {
"height": -2,
"width": 0,
},
"shadowOpacity": 0.5,
"shadowRadius": 2,
},
"shadowOpacity": 0.5,
"shadowRadius": 2,
}
Object {
"shadowColor": "rgba(34, 34, 34, 1)",
},
]
}
>
<LogBoxButton
@@ -77,18 +82,23 @@ exports[`LogBoxInspectorFooter should render fatal button 1`] = `
exports[`LogBoxInspectorFooter should render fatal button for syntax erorr 1`] = `
<View
style={
Object {
"backgroundColor": "rgba(51, 51, 51, 1)",
"elevation": 1,
"flexDirection": "row",
"shadowColor": "#000",
"shadowOffset": Object {
"height": -2,
"width": 0,
Array [
Object {
"backgroundColor": "rgba(51, 51, 51, 1)",
"elevation": 1,
"flexDirection": "row",
"shadowColor": "#000",
"shadowOffset": Object {
"height": -2,
"width": 0,
},
"shadowOpacity": 0.5,
"shadowRadius": 2,
},
"shadowOpacity": 0.5,
"shadowRadius": 2,
}
Object {
"shadowColor": "rgba(34, 34, 34, 1)",
},
]
}
>
<LogBoxButton
@@ -151,18 +161,23 @@ exports[`LogBoxInspectorFooter should render fatal button for syntax erorr 1`] =
exports[`LogBoxInspectorFooter should render fatal for warning with a fatal 1`] = `
<View
style={
Object {
"backgroundColor": "rgba(51, 51, 51, 1)",
"elevation": 1,
"flexDirection": "row",
"shadowColor": "#000",
"shadowOffset": Object {
"height": -2,
"width": 0,
Array [
Object {
"backgroundColor": "rgba(51, 51, 51, 1)",
"elevation": 1,
"flexDirection": "row",
"shadowColor": "#000",
"shadowOffset": Object {
"height": -2,
"width": 0,
},
"shadowOpacity": 0.5,
"shadowRadius": 2,
},
"shadowOpacity": 0.5,
"shadowRadius": 2,
}
Object {
"shadowColor": "rgba(34, 34, 34, 1)",
},
]
}
>
<LogBoxButton