Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removing Fabric check from UIManagerProvider (#41880)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41880

Pull Request resolved: https://github.com/facebook/react-native/pull/41664

Moving the check for Fabric i.e. `ReactFeatureFlags.enableFabricRenderer` to old JSI Module path logic instead of new UIManagerProvider path for Fabric initialization

Reviewed By: philIip

Differential Revision: D51610399

fbshipit-source-id: 1d868111dd2b65ac8d69198f7ab115ac8a2b43ec
This commit is contained in:
Arushi Kesarwani
2023-12-11 03:40:09 -08:00
committed by Facebook GitHub Bot
parent 6e88d67b8c
commit 8832ddab20
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
+8 -8
View File
@@ -1406,14 +1406,14 @@ public class ReactInstanceManager {
mJSIModulePackage.getJSIModules(
reactContext, catalystInstance.getJavaScriptContextHolder()));
}
if (ReactFeatureFlags.enableFabricRenderer) {
if (mUIManagerProvider != null) {
UIManager uiManager = mUIManagerProvider.createUIManager(reactContext);
uiManager.initialize();
catalystInstance.setFabricUIManager(uiManager);
} else {
catalystInstance.getJSIModule(JSIModuleType.UIManager);
}
// The setFabricUIManager API is valid even if enableFabricRenderer is false because
// apps that override getUIManagerProvider() are indicating they want to use Fabric.
if (mUIManagerProvider != null) {
UIManager uiManager = mUIManagerProvider.createUIManager(reactContext);
uiManager.initialize();
catalystInstance.setFabricUIManager(uiManager);
} else if (ReactFeatureFlags.enableFabricRenderer) {
catalystInstance.getJSIModule(JSIModuleType.UIManager);
}
if (mBridgeIdleDebugListener != null) {
catalystInstance.addBridgeIdleDebugListener(mBridgeIdleDebugListener);