Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove optionality of intersectionRect

Browse Source 
Summary:
Changelog:
[General][Changed] - Mark `intersectionRect` required in `NativeIntersectionObserverEntry` to reflect native logic.

Reviewed By: rubennorte

Differential Revision: D67868219

fbshipit-source-id: cdc15908c0cf687b13d1424a59ee1e2383811ab3
This commit is contained in:
Luna Wei
2025-01-06 13:30:10 -08:00
committed by Facebook GitHub Bot
parent 3744349ed7
commit 8681fc2ab2
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/NativeIntersectionObserver.h
+1 -1
View File
@@ -45,7 +45,7 @@ using NativeIntersectionObserverEntry =
// rootRect
RectAsTuple,
// intersectionRect
std::optional<RectAsTuple>,
RectAsTuple,
// isIntersectingAboveThresholds
bool,
// time
packages/react-native/src/private/webapis/intersectionobserver/specs/NativeIntersectionObserver.js
Vendored
+1 -2
View File
@@ -17,8 +17,7 @@ export type NativeIntersectionObserverEntry = {
targetInstanceHandle: mixed,
targetRect: $ReadOnlyArray<number>, // It's actually a tuple with x, y, width and height
rootRect: $ReadOnlyArray<number>, // It's actually a tuple with x, y, width and height
// TODO(T209328432) - Remove optionality of intersectionRect when native changes are released
intersectionRect: ?$ReadOnlyArray<number>, // It's actually a tuple with x, y, width and height
intersectionRect: $ReadOnlyArray<number>, // It's actually a tuple with x, y, width and height
isIntersectingAboveThresholds: boolean,
time: number,
};