mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Mark benchmark API as unstable (#48570)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48570 Changelog: [internal] We're still iterating on this feature and making sure it reports stable results, so marking it as `unstable` to set expectations. Reviewed By: andrewdacenko Differential Revision: D67975844 fbshipit-source-id: 41e93cb9cb0c887a96178e4a4d5078d1899b2478
This commit is contained in:
1 parent
8d67d51bdc
commit
8310d651e0
3 files changed
+4
-4
No files matched your search
@@ -46,7 +46,7 @@ const DEFAULT_MODE: FantomTestConfigMode =
|
||||
|
||||
const FANTOM_FLAG_FORMAT = /^(\w+):(\w+)$/;
|
||||
|
||||
const FANTOM_BENCHMARK_SUITE_RE = /\nbenchmark(\s*)\.suite\(/g;
|
||||
const FANTOM_BENCHMARK_SUITE_RE = /\nunstable_benchmark(\s*)\.suite\(/g;
|
||||
|
||||
/**
|
||||
* Extracts the Fantom configuration from the test file, specified as part of
|
||||
|
||||
+1
-1
@@ -139,7 +139,7 @@ export function createRoot(rootConfig?: RootConfig): Root {
|
||||
return new Root(rootConfig);
|
||||
}
|
||||
|
||||
export const benchmark = Benchmark;
|
||||
export const unstable_benchmark = Benchmark;
|
||||
|
||||
type FantomConstants = $ReadOnly<{
|
||||
isRunningFromCI: boolean,
|
||||
|
||||
+2
-2
@@ -17,7 +17,7 @@ import type {
|
||||
|
||||
import ReactNativeElement from '../../../../src/private/webapis/dom/nodes/ReactNativeElement';
|
||||
import ReactFabricHostComponent from '../../../ReactNative/ReactFabricPublicInstance/ReactFabricHostComponent';
|
||||
import {benchmark} from '@react-native/fantom';
|
||||
import {unstable_benchmark} from '@react-native/fantom';
|
||||
import nullthrows from 'nullthrows';
|
||||
|
||||
// Create fake parameters for the class.
|
||||
@@ -31,7 +31,7 @@ const viewConfig: ViewConfig = {
|
||||
// $FlowExpectedError[incompatible-type]
|
||||
const internalInstanceHandle: InternalInstanceHandle = {};
|
||||
|
||||
benchmark
|
||||
unstable_benchmark
|
||||
.suite('ReactNativeElement vs. ReactFabricHostComponent')
|
||||
.add('ReactNativeElement', () => {
|
||||
// eslint-disable-next-line no-new
|
||||
|
||||
Reference in new issue
Block a user