mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Run the With hooks around WithRuntimeDecorator::createArrayBuffer (#58935)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58935 `WithRuntimeDecorator` wraps every override in `Around around{with_};` except `createArrayBuffer(std::shared_ptr<MutableBuffer>)`, which calls `RD::createArrayBuffer` directly. It has been like that since external ArrayBuffers were added in https://github.com/facebook/hermes/issues/793, where the overrides next to it did get the guard. `HermesRuntimeImpl::createArrayBuffer` allocates a `JSArrayBuffer` on the GC heap, so on `makeThreadSafeHermesRuntime` it runs without the runtime lock, and reentrancy checks built on `WithRuntimeDecorator` never see the call. facebook/react-native#45042 and facebook/react-native#45049 fixed the same kind of gap for methods that had no `WithRuntimeDecorator` override at all. This one has an override that just skips the guard, so it wasn't caught there. A small stress program shows the race: one thread runs an allocating JS loop on a thread-safe runtime while another creates external ArrayBuffers. In a Debug build it fails the `makeA() calls can not be interleaved` assert in HadesGC. With the guard it runs clean. I didn't add it as a test because it depends on timing. React Native's copy of `decorator.h` has the same line. X-link: https://github.com/facebook/hermes/pull/2204 Test Plan: Added `HermesRuntimeDecoratorTest.CreateArrayBufferCallsWith`. It wraps `makeHermesRuntime()` in a counting `WithRuntimeDecorator`, creates an ArrayBuffer from a `MutableBuffer`, and checks that `before()` and `after()` each ran once. Without the change both counts are 0 and the test fails. With it the test passes, and so does the full `APITests` binary (356 tests) in a Debug + ASan build. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed By: avp Differential Revision: D123939407 Pulled By: lavenzg fbshipit-source-id: 165a7807ecc9cf68f56a1f2b188642dbd68d136d
This commit is contained in:
1 parent
0dbd23bb3f
commit
82def6ea4c
1 file changed
+1
@@ -1005,6 +1005,7 @@ class WithRuntimeDecorator : public RuntimeDecorator<Plain, Base> {
|
||||
}
|
||||
ArrayBuffer createArrayBuffer(
|
||||
std::shared_ptr<MutableBuffer> buffer) override {
|
||||
Around around{with_};
|
||||
return RD::createArrayBuffer(std::move(buffer));
|
||||
}
|
||||
size_t size(const Array& a) override {
|
||||
|
||||
Reference in new issue
Block a user