mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Remove prefersFuseboxFrontend from event reporter (#55549)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/55549 **Context** Clean up the legacy `rn_inspector.html` entry point. React Native DevTools has been the default since 0.76, and we have now removed all internal dependencies at Meta. **This diff** - Remove `prefersFuseboxFrontend` metadata from `unstable_eventReporter` API. Changelog: [Internal] Reviewed By: vzaidman Differential Revision: D93247602 fbshipit-source-id: 278f847433259c98deb121562e34a12ff59058a2
This commit is contained in:
1 parent
755895e167
commit
8250db6ae9
5 files changed
-38
No files matched your search
@@ -457,9 +457,6 @@ export default class Device {
|
||||
this.#deviceEventReporter?.logRequest(debuggerRequest, 'debugger', {
|
||||
pageId: debuggerInfo.pageId,
|
||||
frontendUserAgent: userAgent,
|
||||
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(
|
||||
debuggerInfo.pageId,
|
||||
),
|
||||
});
|
||||
let processedReq = debuggerRequest;
|
||||
|
||||
@@ -680,7 +677,6 @@ export default class Device {
|
||||
this.#deviceEventReporter?.logResponse(parsedPayload, 'device', {
|
||||
pageId,
|
||||
frontendUserAgent: debuggerConnection.userAgent ?? null,
|
||||
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(pageId),
|
||||
});
|
||||
}
|
||||
|
||||
@@ -760,7 +756,6 @@ export default class Device {
|
||||
this.#deviceEventReporter?.logRequest(message, 'proxy', {
|
||||
pageId,
|
||||
frontendUserAgent: reloadablePageDebugger.userAgent ?? null,
|
||||
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(pageId),
|
||||
});
|
||||
this.#sendMessageToDevice({
|
||||
event: 'wrappedEvent',
|
||||
@@ -911,9 +906,6 @@ export default class Device {
|
||||
this.#deviceEventReporter?.logRequest(resumeMessage, 'proxy', {
|
||||
pageId: debuggerInfo.pageId,
|
||||
frontendUserAgent: debuggerInfo.userAgent ?? null,
|
||||
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(
|
||||
debuggerInfo.pageId,
|
||||
),
|
||||
});
|
||||
this.#sendMessageToDevice({
|
||||
event: 'wrappedEvent',
|
||||
@@ -984,7 +976,6 @@ export default class Device {
|
||||
this.#deviceEventReporter?.logResponse(response, 'proxy', {
|
||||
pageId,
|
||||
frontendUserAgent: debuggerInfo.userAgent ?? null,
|
||||
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(pageId),
|
||||
});
|
||||
return null;
|
||||
default:
|
||||
@@ -1064,7 +1055,6 @@ export default class Device {
|
||||
this.#deviceEventReporter?.logResponse(response, 'proxy', {
|
||||
pageId,
|
||||
frontendUserAgent: debuggerInfo.userAgent ?? null,
|
||||
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(pageId),
|
||||
});
|
||||
};
|
||||
const sendErrorResponse = (error: string) => {
|
||||
@@ -1079,7 +1069,6 @@ export default class Device {
|
||||
this.#deviceEventReporter?.logResponse(response, 'proxy', {
|
||||
pageId,
|
||||
frontendUserAgent: debuggerInfo.userAgent ?? null,
|
||||
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(pageId),
|
||||
});
|
||||
};
|
||||
|
||||
@@ -1169,15 +1158,6 @@ export default class Device {
|
||||
}
|
||||
}
|
||||
|
||||
#isPageFuseboxFrontend(pageId: ?string): boolean | null {
|
||||
const page = pageId == null ? null : this.#pages.get(pageId);
|
||||
if (page == null) {
|
||||
return null;
|
||||
}
|
||||
|
||||
return this.#pageHasCapability(page, 'prefersFuseboxFrontend');
|
||||
}
|
||||
|
||||
dangerouslyGetSocket(): WS {
|
||||
return this.#deviceSocket;
|
||||
}
|
||||
|
||||
@@ -30,13 +30,11 @@ type DeviceMetadata = Readonly<{
|
||||
type RequestMetadata = Readonly<{
|
||||
pageId: string | null,
|
||||
frontendUserAgent: string | null,
|
||||
prefersFuseboxFrontend: boolean | null,
|
||||
}>;
|
||||
|
||||
type ResponseMetadata = Readonly<{
|
||||
pageId: string | null,
|
||||
frontendUserAgent: string | null,
|
||||
prefersFuseboxFrontend: boolean | null,
|
||||
}>;
|
||||
|
||||
class DeviceEventReporter {
|
||||
@@ -101,7 +99,6 @@ class DeviceEventReporter {
|
||||
deviceName: this.#metadata.deviceName,
|
||||
pageId: metadata.pageId,
|
||||
frontendUserAgent: metadata.frontendUserAgent,
|
||||
prefersFuseboxFrontend: metadata.prefersFuseboxFrontend,
|
||||
connectionUptime: this.#deviceConnectedTimestamp - Date.now(),
|
||||
});
|
||||
return;
|
||||
@@ -128,7 +125,6 @@ class DeviceEventReporter {
|
||||
deviceName: this.#metadata.deviceName,
|
||||
pageId: pendingCommand.metadata.pageId,
|
||||
frontendUserAgent: pendingCommand.metadata.frontendUserAgent,
|
||||
prefersFuseboxFrontend: metadata.prefersFuseboxFrontend,
|
||||
connectionUptime: this.#deviceConnectedTimestamp - Date.now(),
|
||||
});
|
||||
return;
|
||||
@@ -146,7 +142,6 @@ class DeviceEventReporter {
|
||||
deviceName: this.#metadata.deviceName,
|
||||
pageId: pendingCommand.metadata.pageId,
|
||||
frontendUserAgent: pendingCommand.metadata.frontendUserAgent,
|
||||
prefersFuseboxFrontend: metadata.prefersFuseboxFrontend,
|
||||
connectionUptime: this.#deviceConnectedTimestamp - Date.now(),
|
||||
});
|
||||
}
|
||||
@@ -204,7 +199,6 @@ class DeviceEventReporter {
|
||||
deviceName: this.#metadata.deviceName,
|
||||
pageId: pendingCommand.metadata.pageId,
|
||||
frontendUserAgent: pendingCommand.metadata.frontendUserAgent,
|
||||
prefersFuseboxFrontend: pendingCommand.metadata.prefersFuseboxFrontend,
|
||||
connectionUptime: this.#deviceConnectedTimestamp - Date.now(),
|
||||
});
|
||||
}
|
||||
@@ -246,7 +240,6 @@ class DeviceEventReporter {
|
||||
deviceName: this.#metadata.deviceName,
|
||||
pageId: pendingCommand.metadata.pageId,
|
||||
frontendUserAgent: pendingCommand.metadata.frontendUserAgent,
|
||||
prefersFuseboxFrontend: pendingCommand.metadata.prefersFuseboxFrontend,
|
||||
connectionUptime: this.#deviceConnectedTimestamp - Date.now(),
|
||||
});
|
||||
}
|
||||
|
||||
@@ -31,13 +31,6 @@ export type TargetCapabilityFlags = Readonly<{
|
||||
*/
|
||||
nativeSourceCodeFetching?: boolean,
|
||||
|
||||
/**
|
||||
* The target supports the modern `rn_fusebox.html` entry point.
|
||||
*
|
||||
* In the launch flow, this controls the Chrome DevTools entrypoint that is used.
|
||||
*/
|
||||
prefersFuseboxFrontend?: boolean,
|
||||
|
||||
/**
|
||||
* The target supports multiple concurrent debugger connections.
|
||||
*
|
||||
|
||||
@@ -240,7 +240,6 @@ export default function openDebuggerMiddleware({
|
||||
pageId: target.id,
|
||||
deviceName: target.deviceName,
|
||||
targetDescription: target.description,
|
||||
prefersFuseboxFrontend: true,
|
||||
});
|
||||
return;
|
||||
} catch (e) {
|
||||
|
||||
@@ -18,7 +18,6 @@ type SuccessResult<Props: {...} | void = {}> = {
|
||||
type ErrorResult<ErrorT = unknown, Props: {...} | void = {}> = {
|
||||
status: 'error',
|
||||
error: ErrorT,
|
||||
prefersFuseboxFrontend?: ?boolean,
|
||||
...Props,
|
||||
};
|
||||
|
||||
@@ -46,7 +45,6 @@ export type ReportableEvent =
|
||||
...
|
||||
| SuccessResult<{
|
||||
targetDescription: string,
|
||||
prefersFuseboxFrontend: boolean,
|
||||
...DebuggerSessionIDs,
|
||||
}>
|
||||
| ErrorResult<unknown>
|
||||
@@ -72,7 +70,6 @@ export type ReportableEvent =
|
||||
...DebuggerSessionIDs,
|
||||
...ConnectionUptime,
|
||||
frontendUserAgent: string | null,
|
||||
prefersFuseboxFrontend: boolean | null,
|
||||
...
|
||||
| SuccessResult<void>
|
||||
| CodedErrorResult<
|
||||
|
||||
Reference in new issue
Block a user