Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure that ReactFeatureFlags.useTurboModules is read from memory

Browse Source 
Summary:
`ReactFeatureFlags.useTurboModules` can be written to and read from any number of threads. We should use `volatile` to make sure that all threads read/write this data straight from/to memory.

Changelog:
[Android][Fixed] - Make ReactFeatureFlags.useTurboModules volatile

Reviewed By: fkgozali

Differential Revision: D18505673

fbshipit-source-id: 0b2527b8cb95c1e1aedc6b03b12a6b1e6a6cdaa4
This commit is contained in:
Ramanpreet Nara
2019-11-14 11:03:59 -08:00
committed by Facebook Github Bot
parent ec59e60d45
commit 7f637139e7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java
+2 -2
View File
@@ -26,11 +26,11 @@ public class ReactFeatureFlags {
public static boolean useMapNativeAccessor = false;
/**
* Should this application use TurboModules. If yes, then any module that inherits {@link
* Should this application use TurboModules? If yes, then any module that inherits {@link
* com.facebook.react.turbomodule.core.interfaces.TurboModule} will NOT be passed in to C++
* CatalystInstanceImpl
*/
public static boolean useTurboModules = false;
public static volatile boolean useTurboModules = false;
/**
* Log tags of when a view deleted on the native side {@link