From 7f637139e746e0fd20963b8ea1a6e961d0e381fc Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Thu, 14 Nov 2019 11:01:57 -0800 Subject: [PATCH] Make sure that ReactFeatureFlags.useTurboModules is read from memory Summary: `ReactFeatureFlags.useTurboModules` can be written to and read from any number of threads. We should use `volatile` to make sure that all threads read/write this data straight from/to memory. Changelog: [Android][Fixed] - Make ReactFeatureFlags.useTurboModules volatile Reviewed By: fkgozali Differential Revision: D18505673 fbshipit-source-id: 0b2527b8cb95c1e1aedc6b03b12a6b1e6a6cdaa4 --- .../java/com/facebook/react/config/ReactFeatureFlags.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java index b56aea77d85..031030f2faa 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java +++ b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java @@ -26,11 +26,11 @@ public class ReactFeatureFlags { public static boolean useMapNativeAccessor = false; /** - * Should this application use TurboModules. If yes, then any module that inherits {@link + * Should this application use TurboModules? If yes, then any module that inherits {@link * com.facebook.react.turbomodule.core.interfaces.TurboModule} will NOT be passed in to C++ * CatalystInstanceImpl */ - public static boolean useTurboModules = false; + public static volatile boolean useTurboModules = false; /** * Log tags of when a view deleted on the native side {@link