Migrate ReactClippingViewGroup to Kotlin (#49413)

Summary:
Migrate com.facebook.react.uimanager.ReactClippingViewGroup to Kotlin

## Changelog:

[INTERNAL] - Migrate com.facebook.react.uimanager.ReactClippingViewGroup to Kotlin

Pull Request resolved: https://github.com/facebook/react-native/pull/49413

Test Plan:
```bash
yarn test-android
yarn android
```

Reviewed By: rshest

Differential Revision: D69750532

Pulled By: cortinico

fbshipit-source-id: 50ec87a71b3bd523e1a9518b8bd683a027a4b422
This commit is contained in:
Mateo Guzmán
2025-02-18 07:57:24 -08:00
committed by Facebook GitHub Bot
parent e4e03bd909
commit 7f1edbdcb5
3 changed files with 61 additions and 66 deletions
@@ -1,57 +0,0 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
package com.facebook.react.uimanager;
import android.graphics.Rect;
import android.view.View;
/**
* Interface that should be implemented by {@link View} subclasses that support {@code
* removeClippedSubviews} property. When this property is set for the {@link ViewGroup} subclass
* it's responsible for detaching it's child views that are clipped by the view boundaries. Those
* view boundaries should be determined based on it's parent clipping area and current view's offset
* in parent and doesn't necessarily reflect the view visible area (in a sense of a value that
* {@link View#getGlobalVisibleRect} may return). In order to determine the clipping rect for
* current view helper method {@link ReactClippingViewGroupHelper#calculateClippingRect} can be used
* that takes into account parent view settings.
*/
public interface ReactClippingViewGroup {
/**
* Notify view that clipping area may have changed and it should recalculate the list of children
* that should be attached/detached. This method should be called only when property {@code
* removeClippedSubviews} is set to {@code true} on a view.
*
* <p>CAUTION: Views are responsible for calling {@link #updateClippingRect} on it's children.
* This should happen if child implement {@link ReactClippingViewGroup}, return true from {@link
* #getRemoveClippedSubviews} and clipping rect change of the current view may affect clipping
* rect of this child.
*/
void updateClippingRect();
/**
* Get rectangular bounds to which view is currently clipped to. Called only on views that has set
* {@code removeCLippedSubviews} property value to {@code true}.
*
* @param outClippingRect output clipping rect should be written to this object.
*/
void getClippingRect(Rect outClippingRect);
/**
* Sets property {@code removeClippedSubviews} as a result of property update in JS. Should be
* called only from @{link ViewManager#updateView} method.
*
* <p>Helper method {@link ReactClippingViewGroupHelper#applyRemoveClippedSubviewsProperty} may be
* used by {@link ViewManager} subclass to apply this property based on property update map {@link
* ReactStylesDiffMap}.
*/
void setRemoveClippedSubviews(boolean removeClippedSubviews);
/** Get the current value of {@code removeClippedSubviews} property. */
boolean getRemoveClippedSubviews();
}
@@ -0,0 +1,52 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
package com.facebook.react.uimanager
import android.graphics.Rect
import android.view.View
/**
* Interface that should be implemented by [View] subclasses that support `removeClippedSubviews`
* property. When this property is set for the [ViewGroup] subclass it's responsible for detaching
* it's child views that are clipped by the view boundaries. Those view boundaries should be
* determined based on it's parent clipping area and current view's offset in parent and doesn't
* necessarily reflect the view visible area (in a sense of a value that [View.getGlobalVisibleRect]
* may return). In order to determine the clipping rect for current view helper method
* [ReactClippingViewGroupHelper.calculateClippingRect] can be used that takes into account parent
* view settings.
*/
public interface ReactClippingViewGroup {
/**
* Notify view that clipping area may have changed and it should recalculate the list of children
* that should be attached/detached. This method should be called only when property
* `removeClippedSubviews` is set to `true` on a view.
*
* CAUTION: Views are responsible for calling [updateClippingRect] on it's children. This should
* happen if child implement [ReactClippingViewGroup], return true from [getRemoveClippedSubviews]
* and clipping rect change of the current view may affect clipping rect of this child.
*/
public fun updateClippingRect()
/**
* Get rectangular bounds to which view is currently clipped to. Called only on views that has set
* `removeCLippedSubviews` property value to `true`.
*
* @param outClippingRect output clipping rect should be written to this object.
*/
public fun getClippingRect(outClippingRect: Rect)
/**
* Sets property `removeClippedSubviews` as a result of property update in JS. Should be called
* only from [ViewManager.updateView] method.
*
* Helper method [ReactClippingViewGroupHelper.applyRemoveClippedSubviewsProperty] may be used by
* [ViewManager] subclass to apply this property based on property update map
* [ReactStylesDiffMap].
*/
public var removeClippedSubviews: Boolean
}
@@ -19,17 +19,17 @@ internal class ReactHorizontalScrollContainerLegacyView(context: Context) :
ReactViewGroup(context) {
private val isRTL: Boolean = I18nUtil.instance.isRTL(context)
override fun setRemoveClippedSubviews(removeClippedSubviews: Boolean) {
// removeClippedSubviews logic may read metrics before the offsetting we do in onLayout() and is
// such unsafe
if (isRTL) {
super.setRemoveClippedSubviews(false)
return
override var removeClippedSubviews: Boolean = false
set(value) {
// removeClippedSubviews logic may read metrics before the offsetting we do in onLayout() and
// is such unsafe
if (isRTL) {
field = false
} else {
field = value
}
}
super.setRemoveClippedSubviews(removeClippedSubviews)
}
protected override fun onLayout(changed: Boolean, left: Int, top: Int, right: Int, bottom: Int) {
if (isRTL) {
// When the layout direction is RTL, we expect Yoga to give us a layout