Simplify createTestReactApplicationContext calls (#59508)

Summary:
Pull Request resolved: https://github.com/react/react-native/pull/59508

Use the default `application` argument of `createTestReactApplicationContext`
at every call site instead of passing `RuntimeEnvironment.getApplication()`
explicitly, and expose the helper as `JvmStatic` so the remaining Java test
no longer needs `INSTANCE`. Migrating that test to Kotlin is blocked by
inherited JVM signature clashes when subclassing `BaseViewManagerDelegate`
from Kotlin.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D127584468

fbshipit-source-id: aad8d61bf0553945c217e5db8fb9eda6128440c3
This commit is contained in:
Christoph Purrer authored and meta-codesync[bot] committed 2026-10-27 07:22:58 -07:00
1 parent 98291bcb99
commit 7aff712957
28 files changed
+28 -62

No files matched your search

@@ -38,7 +38,6 @@ import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever
import org.robolectric.Robolectric
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
@Config(shadows = [ShadowArguments::class, ShadowSoLoader::class])
@@ -51,7 +50,7 @@ class RootViewTest {
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
reactContext = spy(createTestReactApplicationContext(RuntimeEnvironment.getApplication()))
reactContext = spy(createTestReactApplicationContext())
doNothing().whenever(reactContext).emitDeviceEvent(any(), any())
DisplayMetricsHolder.initDisplayMetricsIfNotInitialized(reactContext)
@@ -21,6 +21,7 @@ object ReactTestHelper {
@OptIn(UnstableReactNativeAPI::class)
@JvmOverloads
@JvmStatic
fun createTestReactApplicationContext(
application: Application = RuntimeEnvironment.getApplication()
): ReactApplicationContext {
@@ -39,7 +39,6 @@ import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.kotlin.mock
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.Shadows.shadowOf
import org.robolectric.annotation.Config
import org.robolectric.shadow.api.Shadow
@@ -77,8 +76,7 @@ class FabricUIManagerPullModelTest {
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
overrideFeatureFlags()
reactContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
reactContext = ReactTestHelper.createTestReactApplicationContext()
underTest =
FabricUIManager(
reactContext,
@@ -31,7 +31,6 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
@RunWith(RobolectricTestRunner::class)
@@ -55,8 +54,7 @@ class MountingManagerAnimatedPropsTest {
@Before
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
val reactContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
val reactContext = ReactTestHelper.createTestReactApplicationContext()
themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
mountingManager =
MountingManager(ViewManagerRegistry(listOf<ViewManager<*, *>>(ReactViewManager())), {})
@@ -22,7 +22,6 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
/** Tests [FabricUIManager] */
@@ -37,7 +36,7 @@ class MountingManagerTest {
@Before
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
val reactContext = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
val reactContext = createTestReactApplicationContext()
themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
val viewManagers = listOf<ViewManager<*, *>>(ReactViewManager())
mountItemExecutor = MountItemExecutor {
@@ -34,7 +34,6 @@ import org.mockito.kotlin.any
import org.mockito.kotlin.mock
import org.mockito.kotlin.never
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
import org.robolectric.annotation.LooperMode
@@ -60,8 +59,7 @@ class SurfaceMountingManagerEventOrderingTest {
@Before
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
val reactContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
val reactContext = ReactTestHelper.createTestReactApplicationContext()
themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
mountingManager =
MountingManager(
@@ -34,7 +34,6 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
/**
@@ -66,8 +65,7 @@ class SurfaceMountingManagerSynchronousMountPropsTest {
@Before
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
val reactContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
val reactContext = ReactTestHelper.createTestReactApplicationContext()
themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
mountingManager =
MountingManager(
@@ -26,7 +26,6 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
/**
@@ -54,8 +53,7 @@ class SurfaceMountingManagerTest {
@Before
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
val reactContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
val reactContext = ReactTestHelper.createTestReactApplicationContext()
themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
mountingManager =
MountingManager(
@@ -40,7 +40,6 @@ import org.mockito.kotlin.times
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
@RunWith(RobolectricTestRunner::class)
@@ -520,8 +519,7 @@ class TouchEventDispatchTest {
metrics.density = 1f
DisplayMetricsHolder.setScreenDisplayMetrics(metrics)
val reactContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
val reactContext = ReactTestHelper.createTestReactApplicationContext()
val uiQueueThread: MessageQueueThread = mock()
whenever(uiQueueThread.isOnThread()).thenReturn(true)
val queueConfig: ReactQueueConfiguration = mock()
@@ -20,7 +20,6 @@ import org.mockito.kotlin.never
import org.mockito.kotlin.times
import org.mockito.kotlin.verify
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
@RunWith(RobolectricTestRunner::class)
@@ -32,8 +31,7 @@ class ExtraWindowEventListenerTest {
@Before
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
reactContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
reactContext = ReactTestHelper.createTestReactApplicationContext()
window = mock()
}
@@ -28,7 +28,6 @@ import org.junit.runner.RunWith
import org.mockito.MockedStatic
import org.mockito.Mockito.mockStatic
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.Shadows.shadowOf
import org.robolectric.annotation.Config
@@ -52,7 +51,7 @@ class BlobModuleTest {
bytes = ByteArray(120)
Random.Default.nextBytes(bytes)
context = ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
context = ReactTestHelper.createTestReactApplicationContext()
blobModule = BlobModule(context)
blobId = blobModule.store(bytes)
}
@@ -31,8 +31,7 @@ class ClipboardModuleTest {
@Before
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
clipboardModule =
ClipboardModule(createTestReactApplicationContext(RuntimeEnvironment.getApplication()))
clipboardModule = ClipboardModule(createTestReactApplicationContext())
clipboardManager =
RuntimeEnvironment.getApplication().getSystemService(Context.CLIPBOARD_SERVICE)
as ClipboardManager
@@ -48,7 +48,6 @@ import org.mockito.kotlin.times
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
@RunWith(RobolectricTestRunner::class)
@@ -81,7 +80,7 @@ class DeviceInfoModuleTest {
fakeLandscapeDisplayMetrics.putInt("height", 100)
displayMetricsHolder = mockStatic(DisplayMetricsHolder::class.java)
reactContext = spy(createTestReactApplicationContext(RuntimeEnvironment.getApplication()))
reactContext = spy(createTestReactApplicationContext())
doReturn(true).whenever(reactContext).hasActiveReactInstance()
doNothing()
.whenever(reactContext)
@@ -46,7 +46,6 @@ import org.mockito.kotlin.never
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
/** The payload is never decoded — every test here mocks the image pipeline. */
@@ -63,8 +62,7 @@ class ImageLoaderModuleTest {
@Before
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
reactContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
reactContext = ReactTestHelper.createTestReactApplicationContext()
imageLoaderModule = ImageLoaderModule(reactContext)
mockedHelper = mockStatic(ResourceDrawableIdHelper::class.java)
@@ -39,8 +39,7 @@ class ShareModuleTest {
ReactNativeFeatureFlagsForTests.setUp()
activityController = Robolectric.buildActivity(FragmentActivity::class.java)
val activity = activityController.create().start().resume().get()
val applicationContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
val applicationContext = ReactTestHelper.createTestReactApplicationContext()
applicationContext.onNewIntent(activity, Intent())
shareModule = ShareModule(applicationContext)
}
@@ -22,7 +22,6 @@ import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;
import org.robolectric.annotation.Config;
@RunWith(RobolectricTestRunner.class)
@@ -38,9 +37,7 @@ public class BaseViewManagerDelegateTest {
// (non-JNI) accessor so Robolectric doesn't try to load react_featureflagsjni.
ReactNativeFeatureFlagsForTests.INSTANCE.setUp();
viewManager = mock(ReactViewManager.class);
ReactApplicationContext context =
ReactTestHelper.INSTANCE.createTestReactApplicationContext(
RuntimeEnvironment.getApplication());
ReactApplicationContext context = ReactTestHelper.createTestReactApplicationContext();
ThemedReactContext themedReactContext = new ThemedReactContext(context, context, null, -1);
view = new ReactViewGroup(themedReactContext);
delegate = new BaseViewManagerDelegate<>(viewManager) {};
@@ -40,7 +40,6 @@ import org.mockito.kotlin.spy
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
@Config(shadows = [ShadowArguments::class, ShadowSoLoader::class])
@@ -54,7 +53,7 @@ class ReactAccessibilityDelegateTest {
@Before
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
reactContext = spy(createTestReactApplicationContext(RuntimeEnvironment.getApplication()))
reactContext = spy(createTestReactApplicationContext())
themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
view = ReactViewGroup(themedReactContext).apply { id = 100 }
accessibilityDelegate = ReactAccessibilityDelegate(view, false, 0)
@@ -21,7 +21,6 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
/** Verify [View] view property being applied properly by [SimpleViewManager] */
@@ -54,7 +53,7 @@ class SimpleViewPropertyTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
context = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
context = createTestReactApplicationContext()
themedContext = ThemedReactContext(context, context, null, surfaceId)
manager = ConcreteViewManager()
}
@@ -33,8 +33,7 @@ class ThemedReactContextTest {
@Before
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
reactApplicationContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
reactApplicationContext = ReactTestHelper.createTestReactApplicationContext()
themedReactContext =
ThemedReactContext(reactApplicationContext, RuntimeEnvironment.getApplication(), null, -1)
window = mock()
@@ -50,7 +50,6 @@ import org.mockito.kotlin.reset
import org.mockito.kotlin.times
import org.mockito.kotlin.verify
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
/**
@@ -76,7 +75,7 @@ class ReactImagePropertyTest {
flogMock = mockStatic(FLog::class.java)
SoLoader.setInTestMode()
context = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
context = createTestReactApplicationContext()
themeContext = ThemedReactContext(context, context, null, -1)
Fresco.initialize(context)
DisplayMetricsHolder.setScreenDisplayMetrics(DisplayMetrics())
@@ -68,8 +68,7 @@ class ReactScrollViewHelperFlingAnimatorTest {
mockChild = mock()
mockAnimator = ValueAnimator()
mockEventDispatcher = mock()
mockContext =
ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
mockContext = ReactTestHelper.createTestReactApplicationContext()
mockScrollView = mock<MockScrollView>()
@@ -37,7 +37,6 @@ import org.mockito.Mockito.mockStatic
import org.mockito.kotlin.any
import org.mockito.kotlin.mock
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
/** Verifies the direction of wheel and joystick scrolling in regular and inverted ScrollViews. */
@@ -53,7 +52,7 @@ class ReactScrollViewInvertedScrollTest {
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
SoLoader.setInTestMode()
val context = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
val context = createTestReactApplicationContext()
themedContext = ThemedReactContext(context, context, null, -1)
DisplayMetricsHolder.setScreenDisplayMetrics(DisplayMetrics())
uiManagerHelperMock = mockStatic(UIManagerHelper::class.java)
@@ -31,7 +31,6 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
/** Verifies border radius properties applied by the vertical and horizontal ScrollView managers. */
@@ -46,7 +45,7 @@ class ReactScrollViewPropertyTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
context = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
context = createTestReactApplicationContext()
themedContext = ThemedReactContext(context, context, null, -1)
DisplayMetricsHolder.setScreenDisplayMetrics(DisplayMetrics())
}
@@ -41,7 +41,6 @@ import org.mockito.kotlin.mock
import org.mockito.kotlin.verify
import org.robolectric.ParameterizedRobolectricTestRunner
import org.robolectric.Robolectric
import org.robolectric.RuntimeEnvironment
import org.robolectric.Shadows.shadowOf
import org.robolectric.android.controller.ActivityController
import org.robolectric.annotation.Config
@@ -81,7 +80,7 @@ class ReactScrollViewTouchCancelTest(private val kind: String) {
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
SoLoader.setInTestMode()
context = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
context = createTestReactApplicationContext()
context.scrollEndedListeners.addListener(scrollEndedListener)
themedContext = ThemedReactContext(context, context, null, -1)
DisplayMetricsHolder.setScreenDisplayMetrics(DisplayMetrics())
@@ -29,7 +29,6 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
/** Verify view properties are being applied correctly by [ReactTextViewManager] */
@@ -49,7 +48,7 @@ class ReactTextViewPropertyTest {
override fun enableViewRecycling(): Boolean = true
},
)
context = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
context = createTestReactApplicationContext()
themedContext = ThemedReactContext(context, context, null, -1)
manager = ReactTextViewManager()
DisplayMetricsHolder.setScreenDisplayMetrics(DisplayMetrics())
@@ -26,7 +26,6 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
@RunWith(RobolectricTestRunner::class)
@@ -39,7 +38,7 @@ class ReactEditTextKeyEventTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
val context = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
val context = createTestReactApplicationContext()
val themedContext = ThemedReactContext(context, context.baseContext, null, ID_NULL)
manager = ReactTextInputManager()
DisplayMetricsHolder.setScreenDisplayMetrics(DisplayMetrics())
@@ -50,7 +50,7 @@ class ReactEditTextOutlineTest {
@Before
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
val context = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
val context = createTestReactApplicationContext()
DisplayMetricsHolder.setScreenDisplayMetrics(DisplayMetrics())
view =
ReactTextInputManager().createViewInstance(ThemedReactContext(context, context, null, -1))
@@ -70,7 +70,7 @@ class ReactTextInputPropertyTest {
fun setup() {
ReactNativeFeatureFlagsForTests.setUp()
val application = RuntimeEnvironment.getApplication()
context = createTestReactApplicationContext(application)
context = createTestReactApplicationContext()
themedContext = ThemedReactContext(context, application, null, ID_NULL)
manager = ReactTextInputManager()
DisplayMetricsHolder.setScreenDisplayMetrics(DisplayMetrics())