mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Backport Hermes release fix on main (#37685)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37685 I'm backporting this comming `60a452b4853dc5651c465867344904dd6fc86703` from the release branch of 0.72-stable to main which fixes this issue in the Android NDK: https://github.com/android/ndk/issues/1740#issuecomment-1198438260 Changelog: [Internal] [Changed] - Backport Hermes release fix on `main` Reviewed By: mdvacca Differential Revision: D46398346 fbshipit-source-id: 593ca9523cb223e7c2d9fe6cccc1abb3ed331203
This commit is contained in:
committed by
Facebook GitHub Bot
parent
2d07d5f160
commit
7a1229ea0f
@@ -181,6 +181,9 @@ android {
|
||||
// This has the (unlucky) side effect of letting AGP call the build
|
||||
// tasks `configureCMakeRelease` while is actually building the debug flavor.
|
||||
arguments "-DCMAKE_BUILD_TYPE=Release"
|
||||
// Adding -O3 to handle the issue here: https://github.com/android/ndk/issues/1740#issuecomment-1198438260
|
||||
// The old NDK toolchain is not passing -O3 correctly for release CMake builds. This is fixed in NDK 25 and can be removed once we're there.
|
||||
cppFlags "-O3"
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user