mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix missing willPerformAsynchronously parameter in calls to MountingCoordinator::pullTransaction (#51618)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51618 Changelog: [internal] This sets the argument to `pullTransaction` to `true` in the cases where the call is done from the JS thread and the transactions are mounted asynchronously in the UI thread (basically platforms using the push model for mounting coordinator). It was missing on an experiment for Android (compatibility mode for Props 2.0) Reviewed By: lenaic Differential Revision: D75439105 fbshipit-source-id: a106a3a674e44b0cf2603782302343f60ee5450e
This commit is contained in:
committed by
Facebook GitHub Bot
parent
6d7da0cc37
commit
77c860898e
+2
-1
@@ -630,7 +630,8 @@ void FabricUIManagerBinding::schedulerShouldRenderTransactions(
|
||||
return;
|
||||
}
|
||||
if (ReactNativeFeatureFlags::enableAccumulatedUpdatesInRawPropsAndroid()) {
|
||||
auto mountingTransaction = mountingCoordinator->pullTransaction();
|
||||
auto mountingTransaction = mountingCoordinator->pullTransaction(
|
||||
/* willPerformAsynchronously = */ true);
|
||||
if (mountingTransaction.has_value()) {
|
||||
auto transaction = std::move(*mountingTransaction);
|
||||
mountingManager->executeMount(transaction);
|
||||
|
||||
@@ -62,7 +62,6 @@ class MountingCoordinator final {
|
||||
* `true` until `didPerformAsyncTransactions` is called.
|
||||
*/
|
||||
std::optional<MountingTransaction> pullTransaction(
|
||||
// TODO: Clean up this parameter when Android migrates to a pull model.
|
||||
bool willPerformAsynchronously = false) const;
|
||||
|
||||
/*
|
||||
|
||||
Reference in New Issue
Block a user