fixing ATOMIC_VAR_INIT call (#26238)

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Summary:
We're trying to build react-native on Windows (part of the Microsoft\react-native-windows project) with MSVC compiler with WITH_FBSYSTRACE set to true (to route the traces to ETW). This change is to fix a compilation error due to the non standard usage of ATOMIC_VAR_INIT macro called with no parameters. It's not absolutely clear to me the objective of this macro in the standard at all (to be used in c context ?), and which compiler does support this parameterless version (gcc?).

Also, I'm more inclined towards changing the statement to just "std::atomic_uint_least32_t m_systraceCookie{};". Please confirm.

## Changelog

[General] [Fixed] - Removing the non-standard usage of ATOMIC_VAR_INIT macro from code with systrace enabled
Pull Request resolved: https://github.com/facebook/react-native/pull/26238

Test Plan: Build verification should suffice as there is no semantic change introduced by this change.

Differential Revision: D17259213

Pulled By: cpojer

fbshipit-source-id: 9fe44f9220f18399a58f94f0f01d5fa93e6458e0

This commit is contained in:

Anandraj

2019-09-09 07:55:25 -07:00

committed by

Facebook Github Bot

parent cc35d0f1bc

commit 75a7a52db4

1 changed files with 1 additions and 1 deletions

									
										ReactCommon/cxxreact/NativeToJsBridge.h
									
		+1
		-1
	
												View File
												
				@@ -107,7 +107,7 @@ private:

				  bool m_applicationScriptHasFailure = false;

				  #ifdef WITH_FBSYSTRACE

				  std::atomic_uint_least32_t m_systraceCookie = ATOMIC_VAR_INIT();

				  std::atomic_uint_least32_t m_systraceCookie = ATOMIC_VAR_INIT(0);

				  #endif

				};