Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prepare bolts.Task to be safe to be usde from Kotlin

Browse Source 
Summary:
In this diff I analyzed bolts.Task class to ensure it's ready to be used from kotlin.
I won't convert bolts.Task to kotlin, but this is necessary to be able to convert its callsites (ReactHost) to kotlin

This is a 'continuation' of the previous diff, I splitted in 2 because Task is a very large class and it's worth analyzing separately.

bypass-github-export-checks

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D46194126

fbshipit-source-id: 765af7683fa62814747c7d8516d311cffabac3c1
This commit is contained in:
David Vacca
2023-05-30 13:13:36 -07:00
committed by Facebook GitHub Bot
parent dfb42a3946
commit 730ca35405
1 changed files with 125 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/internal/bolts/Task.java
+125 -108
View File
@@ -7,6 +7,8 @@
package com.facebook.react.bridgeless.internal.bolts;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
@@ -59,14 +61,14 @@ public class Task<TResult> {
* @param t the task
* @param e the exception
*/
void unobservedException(Task<?> t, UnobservedTaskException e);
void unobservedException(@NonNull Task<?> t, @NonNull UnobservedTaskException e);
}
// null unless explicitly set
private static volatile UnobservedExceptionHandler unobservedExceptionHandler;
/** Returns the handler invoked when a task has an unobserved exception or {@code null}. */
public static UnobservedExceptionHandler getUnobservedExceptionHandler() {
public static @Nullable UnobservedExceptionHandler getUnobservedExceptionHandler() {
return unobservedExceptionHandler;
}
@@ -83,15 +85,15 @@ public class Task<TResult> {
private final Object lock = new Object();
private boolean complete;
private boolean cancelled;
private TResult result;
private Exception error;
@Nullable private TResult result;
@Nullable private Exception error;
private boolean errorHasBeenObserved;
private UnobservedErrorNotifier unobservedErrorNotifier;
private List<Continuation<TResult, Void>> continuations = new ArrayList<>();
@Nullable private UnobservedErrorNotifier unobservedErrorNotifier;
@Nullable private List<Continuation<TResult, Void>> continuations = new ArrayList<>();
/* package */ Task() {}
private Task(TResult result) {
private Task(@Nullable TResult result) {
trySetResult(result);
}
@@ -103,7 +105,7 @@ public class Task<TResult> {
}
}
public static <TResult> TaskCompletionSource create() {
public static @NonNull <TResult> TaskCompletionSource create() {
Task<TResult> task = new Task<>();
return new TaskCompletionSource();
}
@@ -133,14 +135,14 @@ public class Task<TResult> {
}
/** @return The result of the task, if set. {@code null} otherwise. */
public TResult getResult() {
public @Nullable TResult getResult() {
synchronized (lock) {
return result;
}
}
/** @return The error for the task, if set. {@code null} otherwise. */
public Exception getError() {
public @Nullable Exception getError() {
synchronized (lock) {
if (error != null) {
errorHasBeenObserved = true;
@@ -168,7 +170,8 @@ public class Task<TResult> {
* @return {@code true} if the task completed (has a result, an error, or was cancelled). {@code
* false} otherwise.
*/
public boolean waitForCompletion(long duration, TimeUnit timeUnit) throws InterruptedException {
public boolean waitForCompletion(long duration, @NonNull TimeUnit timeUnit)
throws InterruptedException {
synchronized (lock) {
if (!isCompleted()) {
lock.wait(timeUnit.toMillis(duration));
@@ -179,7 +182,7 @@ public class Task<TResult> {
/** Creates a completed task with the given value. */
@SuppressWarnings("unchecked")
public static <TResult> Task<TResult> forResult(TResult value) {
public static @NonNull <TResult> Task<TResult> forResult(@Nullable TResult value) {
if (value == null) {
return (Task<TResult>) TASK_NULL;
}
@@ -192,7 +195,7 @@ public class Task<TResult> {
}
/** Creates a faulted task with the given error. */
public static <TResult> Task<TResult> forError(Exception error) {
public static @NonNull <TResult> Task<TResult> forError(@Nullable Exception error) {
TaskCompletionSource<TResult> tcs = new TaskCompletionSource<>();
tcs.setError(error);
return tcs.getTask();
@@ -200,7 +203,7 @@ public class Task<TResult> {
/** Creates a cancelled task. */
@SuppressWarnings("unchecked")
public static <TResult> Task<TResult> cancelled() {
public static @NonNull <TResult> Task<TResult> cancelled() {
return (Task<TResult>) TASK_CANCELLED;
}
@@ -210,7 +213,7 @@ public class Task<TResult> {
* @param delay The number of milliseconds to wait before completing the returned task. Zero and
* negative values are treated as requests for immediate execution.
*/
public static Task<Void> delay(long delay) {
public static @NonNull Task<Void> delay(long delay) {
return delay(delay, BoltsExecutors.scheduled(), null);
}
@@ -222,12 +225,15 @@ public class Task<TResult> {
* @param cancellationToken The optional cancellation token that will be checked prior to
* completing the returned task.
*/
public static Task<Void> delay(long delay, CancellationToken cancellationToken) {
public static @NonNull Task<Void> delay(
long delay, @Nullable CancellationToken cancellationToken) {
return delay(delay, BoltsExecutors.scheduled(), cancellationToken);
}
/* package */ static Task<Void> delay(
long delay, ScheduledExecutorService executor, final CancellationToken cancellationToken) {
/* package */ static @NonNull Task<Void> delay(
long delay,
@NonNull ScheduledExecutorService executor,
@Nullable final CancellationToken cancellationToken) {
if (cancellationToken != null && cancellationToken.isCancellationRequested()) {
return Task.cancelled();
}
@@ -266,14 +272,14 @@ public class Task<TResult> {
* Makes a fluent cast of a Task's result possible, avoiding an extra continuation just to cast
* the type of the result.
*/
public <TOut> Task<TOut> cast() {
public @NonNull <TOut> Task<TOut> cast() {
@SuppressWarnings("unchecked")
Task<TOut> task = (Task<TOut>) this;
return task;
}
/** Turns a Task<T> into a Task<Void>, dropping any result. */
public Task<Void> makeVoid() {
public @NonNull Task<Void> makeVoid() {
return this.continueWithTask(
new Continuation<TResult, Task<Void>>() {
@Override
@@ -295,13 +301,14 @@ public class Task<TResult> {
* <p>If you want to cancel the resulting Task throw a {@link
* java.util.concurrent.CancellationException} from the callable.
*/
public static <TResult> Task<TResult> callInBackground(Callable<TResult> callable) {
public static @NonNull <TResult> Task<TResult> callInBackground(
@NonNull Callable<TResult> callable) {
return call(callable, BACKGROUND_EXECUTOR, null);
}
/** Invokes the callable on a background thread, returning a Task to represent the operation. */
public static <TResult> Task<TResult> callInBackground(
Callable<TResult> callable, CancellationToken ct) {
public static @NonNull <TResult> Task<TResult> callInBackground(
@NonNull Callable<TResult> callable, @Nullable CancellationToken ct) {
return call(callable, BACKGROUND_EXECUTOR, ct);
}
@@ -311,13 +318,16 @@ public class Task<TResult> {
* <p>If you want to cancel the resulting Task throw a {@link
* java.util.concurrent.CancellationException} from the callable.
*/
public static <TResult> Task<TResult> call(final Callable<TResult> callable, Executor executor) {
public static @NonNull <TResult> Task<TResult> call(
@NonNull final Callable<TResult> callable, @NonNull Executor executor) {
return call(callable, executor, null);
}
/** Invokes the callable using the given executor, returning a Task to represent the operation. */
public static <TResult> Task<TResult> call(
final Callable<TResult> callable, Executor executor, final CancellationToken ct) {
public static @NonNull <TResult> Task<TResult> call(
@NonNull final Callable<TResult> callable,
@NonNull Executor executor,
@Nullable final CancellationToken ct) {
final TaskCompletionSource<TResult> tcs = new TaskCompletionSource<>();
try {
executor.execute(
@@ -351,13 +361,13 @@ public class Task<TResult> {
* <p>If you want to cancel the resulting Task throw a {@link
* java.util.concurrent.CancellationException} from the callable.
*/
public static <TResult> Task<TResult> call(final Callable<TResult> callable) {
public static @NonNull <TResult> Task<TResult> call(@NonNull final Callable<TResult> callable) {
return call(callable, IMMEDIATE_EXECUTOR, null);
}
/** Invokes the callable on the current thread, producing a Task. */
public static <TResult> Task<TResult> call(
final Callable<TResult> callable, CancellationToken ct) {
public static @NonNull <TResult> Task<TResult> call(
@NonNull final Callable<TResult> callable, @Nullable CancellationToken ct) {
return call(callable, IMMEDIATE_EXECUTOR, ct);
}
@@ -372,8 +382,8 @@ public class Task<TResult> {
* @return A task that represents the completion of one of the supplied tasks. The return task's
* result is the task that completed.
*/
public static <TResult> Task<Task<TResult>> whenAnyResult(
Collection<? extends Task<TResult>> tasks) {
public static @NonNull <TResult> Task<Task<TResult>> whenAnyResult(
@NonNull Collection<? extends Task<TResult>> tasks) {
if (tasks.size() == 0) {
return Task.forResult(null);
}
@@ -410,7 +420,7 @@ public class Task<TResult> {
* Result is the task that completed.
*/
@SuppressWarnings("unchecked")
public static Task<Task<?>> whenAny(Collection<? extends Task<?>> tasks) {
public static @NonNull Task<Task<?>> whenAny(@NonNull Collection<? extends Task<?>> tasks) {
if (tasks.size() == 0) {
return Task.forResult(null);
}
@@ -462,8 +472,8 @@ public class Task<TResult> {
* @return A Task that will resolve to {@code List&lt;TResult&gt;} when all the tasks are
* resolved.
*/
public static <TResult> Task<List<TResult>> whenAllResult(
final Collection<? extends Task<TResult>> tasks) {
public static @NonNull <TResult> Task<List<TResult>> whenAllResult(
@NonNull final Collection<? extends Task<TResult>> tasks) {
return whenAll(tasks)
.onSuccess(
new Continuation<Void, List<TResult>>() {
@@ -502,7 +512,7 @@ public class Task<TResult> {
* @param tasks The tasks that the return value will wait for before completing.
* @return A Task that will resolve to {@code Void} when all the tasks are resolved.
*/
public static Task<Void> whenAll(Collection<? extends Task<?>> tasks) {
public static @NonNull Task<Void> whenAll(@NonNull Collection<? extends Task<?>> tasks) {
if (tasks.size() == 0) {
return Task.forResult(null);
}
@@ -558,8 +568,8 @@ public class Task<TResult> {
* Continues a task with the equivalent of a Task-based while loop, where the body of the loop is
* a task continuation.
*/
public Task<Void> continueWhile(
Callable<Boolean> predicate, Continuation<Void, Task<Void>> continuation) {
public @NonNull Task<Void> continueWhile(
@NonNull Callable<Boolean> predicate, @NonNull Continuation<Void, Task<Void>> continuation) {
return continueWhile(predicate, continuation, IMMEDIATE_EXECUTOR, null);
}
@@ -567,10 +577,10 @@ public class Task<TResult> {
* Continues a task with the equivalent of a Task-based while loop, where the body of the loop is
* a task continuation.
*/
public Task<Void> continueWhile(
Callable<Boolean> predicate,
Continuation<Void, Task<Void>> continuation,
CancellationToken ct) {
public @NonNull Task<Void> continueWhile(
@NonNull Callable<Boolean> predicate,
@NonNull Continuation<Void, Task<Void>> continuation,
@Nullable CancellationToken ct) {
return continueWhile(predicate, continuation, IMMEDIATE_EXECUTOR, ct);
}
@@ -578,10 +588,10 @@ public class Task<TResult> {
* Continues a task with the equivalent of a Task-based while loop, where the body of the loop is
* a task continuation.
*/
public Task<Void> continueWhile(
final Callable<Boolean> predicate,
final Continuation<Void, Task<Void>> continuation,
final Executor executor) {
public @NonNull Task<Void> continueWhile(
@NonNull final Callable<Boolean> predicate,
@NonNull final Continuation<Void, Task<Void>> continuation,
@NonNull final Executor executor) {
return continueWhile(predicate, continuation, executor, null);
}
@@ -589,11 +599,11 @@ public class Task<TResult> {
* Continues a task with the equivalent of a Task-based while loop, where the body of the loop is
* a task continuation.
*/
public Task<Void> continueWhile(
final Callable<Boolean> predicate,
final Continuation<Void, Task<Void>> continuation,
final Executor executor,
final CancellationToken ct) {
public @NonNull Task<Void> continueWhile(
@NonNull final Callable<Boolean> predicate,
@NonNull final Continuation<Void, Task<Void>> continuation,
@NonNull final Executor executor,
@Nullable final CancellationToken ct) {
final Capture<Continuation<Void, Task<Void>>> predicateContinuation = new Capture<>();
predicateContinuation.set(
new Continuation<Void, Task<Void>>() {
@@ -619,8 +629,9 @@ public class Task<TResult> {
* completes after the continuation has finished running. This allows the continuation to be
* scheduled on different thread.
*/
public <TContinuationResult> Task<TContinuationResult> continueWith(
final Continuation<TResult, TContinuationResult> continuation, final Executor executor) {
public @NonNull <TContinuationResult> Task<TContinuationResult> continueWith(
@NonNull final Continuation<TResult, TContinuationResult> continuation,
@NonNull final Executor executor) {
return continueWith(continuation, executor, null);
}
@@ -629,10 +640,10 @@ public class Task<TResult> {
* completes after the continuation has finished running. This allows the continuation to be
* scheduled on different thread.
*/
public <TContinuationResult> Task<TContinuationResult> continueWith(
final Continuation<TResult, TContinuationResult> continuation,
final Executor executor,
final CancellationToken ct) {
public @NonNull <TContinuationResult> Task<TContinuationResult> continueWith(
@NonNull final Continuation<TResult, TContinuationResult> continuation,
@NonNull final Executor executor,
@Nullable final CancellationToken ct) {
boolean completed;
final TaskCompletionSource<TContinuationResult> tcs = new TaskCompletionSource<>();
synchronized (lock) {
@@ -658,8 +669,8 @@ public class Task<TResult> {
* Adds a synchronous continuation to this task, returning a new task that completes after the
* continuation has finished running.
*/
public <TContinuationResult> Task<TContinuationResult> continueWith(
Continuation<TResult, TContinuationResult> continuation) {
public @NonNull <TContinuationResult> Task<TContinuationResult> continueWith(
@NonNull Continuation<TResult, TContinuationResult> continuation) {
return continueWith(continuation, IMMEDIATE_EXECUTOR, null);
}
@@ -667,8 +678,9 @@ public class Task<TResult> {
* Adds a synchronous continuation to this task, returning a new task that completes after the
* continuation has finished running.
*/
public <TContinuationResult> Task<TContinuationResult> continueWith(
Continuation<TResult, TContinuationResult> continuation, CancellationToken ct) {
public @NonNull <TContinuationResult> Task<TContinuationResult> continueWith(
@NonNull Continuation<TResult, TContinuationResult> continuation,
@Nullable CancellationToken ct) {
return continueWith(continuation, IMMEDIATE_EXECUTOR, ct);
}
@@ -676,9 +688,9 @@ public class Task<TResult> {
* Adds an Task-based continuation to this task that will be scheduled using the executor,
* returning a new task that completes after the task returned by the continuation has completed.
*/
public <TContinuationResult> Task<TContinuationResult> continueWithTask(
final Continuation<TResult, Task<TContinuationResult>> continuation,
final Executor executor) {
public @NonNull <TContinuationResult> Task<TContinuationResult> continueWithTask(
@NonNull final Continuation<TResult, Task<TContinuationResult>> continuation,
@NonNull final Executor executor) {
return continueWithTask(continuation, executor, null);
}
@@ -686,10 +698,10 @@ public class Task<TResult> {
* Adds an Task-based continuation to this task that will be scheduled using the executor,
* returning a new task that completes after the task returned by the continuation has completed.
*/
public <TContinuationResult> Task<TContinuationResult> continueWithTask(
final Continuation<TResult, Task<TContinuationResult>> continuation,
final Executor executor,
final CancellationToken ct) {
public @NonNull <TContinuationResult> Task<TContinuationResult> continueWithTask(
@NonNull final Continuation<TResult, Task<TContinuationResult>> continuation,
@NonNull final Executor executor,
@Nullable final CancellationToken ct) {
boolean completed;
final TaskCompletionSource<TContinuationResult> tcs = new TaskCompletionSource<>();
synchronized (lock) {
@@ -715,8 +727,8 @@ public class Task<TResult> {
* Adds an asynchronous continuation to this task, returning a new task that completes after the
* task returned by the continuation has completed.
*/
public <TContinuationResult> Task<TContinuationResult> continueWithTask(
Continuation<TResult, Task<TContinuationResult>> continuation) {
public @NonNull <TContinuationResult> Task<TContinuationResult> continueWithTask(
@NonNull Continuation<TResult, Task<TContinuationResult>> continuation) {
return continueWithTask(continuation, IMMEDIATE_EXECUTOR, null);
}
@@ -724,8 +736,9 @@ public class Task<TResult> {
* Adds an asynchronous continuation to this task, returning a new task that completes after the
* task returned by the continuation has completed.
*/
public <TContinuationResult> Task<TContinuationResult> continueWithTask(
Continuation<TResult, Task<TContinuationResult>> continuation, CancellationToken ct) {
public @NonNull <TContinuationResult> Task<TContinuationResult> continueWithTask(
@NonNull Continuation<TResult, Task<TContinuationResult>> continuation,
@Nullable CancellationToken ct) {
return continueWithTask(continuation, IMMEDIATE_EXECUTOR, ct);
}
@@ -733,8 +746,9 @@ public class Task<TResult> {
* Runs a continuation when a task completes successfully, forwarding along {@link
* java.lang.Exception} or cancellation.
*/
public <TContinuationResult> Task<TContinuationResult> onSuccess(
final Continuation<TResult, TContinuationResult> continuation, Executor executor) {
public @NonNull <TContinuationResult> Task<TContinuationResult> onSuccess(
@NonNull final Continuation<TResult, TContinuationResult> continuation,
@NonNull Executor executor) {
return onSuccess(continuation, executor, null);
}
@@ -742,10 +756,10 @@ public class Task<TResult> {
* Runs a continuation when a task completes successfully, forwarding along {@link
* java.lang.Exception} or cancellation.
*/
public <TContinuationResult> Task<TContinuationResult> onSuccess(
final Continuation<TResult, TContinuationResult> continuation,
Executor executor,
final CancellationToken ct) {
public @NonNull <TContinuationResult> Task<TContinuationResult> onSuccess(
@NonNull final Continuation<TResult, TContinuationResult> continuation,
@NonNull Executor executor,
@Nullable final CancellationToken ct) {
return continueWithTask(
new Continuation<TResult, Task<TContinuationResult>>() {
@Override
@@ -770,8 +784,8 @@ public class Task<TResult> {
* Runs a continuation when a task completes successfully, forwarding along {@link
* java.lang.Exception}s or cancellation.
*/
public <TContinuationResult> Task<TContinuationResult> onSuccess(
final Continuation<TResult, TContinuationResult> continuation) {
public @NonNull <TContinuationResult> Task<TContinuationResult> onSuccess(
@NonNull final Continuation<TResult, TContinuationResult> continuation) {
return onSuccess(continuation, IMMEDIATE_EXECUTOR, null);
}
@@ -779,8 +793,9 @@ public class Task<TResult> {
* Runs a continuation when a task completes successfully, forwarding along {@link
* java.lang.Exception}s or cancellation.
*/
public <TContinuationResult> Task<TContinuationResult> onSuccess(
final Continuation<TResult, TContinuationResult> continuation, CancellationToken ct) {
public @NonNull <TContinuationResult> Task<TContinuationResult> onSuccess(
@NonNull final Continuation<TResult, TContinuationResult> continuation,
@Nullable CancellationToken ct) {
return onSuccess(continuation, IMMEDIATE_EXECUTOR, ct);
}
@@ -788,8 +803,9 @@ public class Task<TResult> {
* Runs a continuation when a task completes successfully, forwarding along {@link
* java.lang.Exception}s or cancellation.
*/
public <TContinuationResult> Task<TContinuationResult> onSuccessTask(
final Continuation<TResult, Task<TContinuationResult>> continuation, Executor executor) {
public @NonNull <TContinuationResult> Task<TContinuationResult> onSuccessTask(
@NonNull final Continuation<TResult, Task<TContinuationResult>> continuation,
@NonNull Executor executor) {
return onSuccessTask(continuation, executor, null);
}
@@ -797,10 +813,10 @@ public class Task<TResult> {
* Runs a continuation when a task completes successfully, forwarding along {@link
* java.lang.Exception}s or cancellation.
*/
public <TContinuationResult> Task<TContinuationResult> onSuccessTask(
final Continuation<TResult, Task<TContinuationResult>> continuation,
Executor executor,
final CancellationToken ct) {
public @NonNull <TContinuationResult> Task<TContinuationResult> onSuccessTask(
@NonNull final Continuation<TResult, Task<TContinuationResult>> continuation,
@NonNull Executor executor,
@Nullable final CancellationToken ct) {
return continueWithTask(
new Continuation<TResult, Task<TContinuationResult>>() {
@Override
@@ -825,8 +841,8 @@ public class Task<TResult> {
* Runs a continuation when a task completes successfully, forwarding along {@link
* java.lang.Exception}s or cancellation.
*/
public <TContinuationResult> Task<TContinuationResult> onSuccessTask(
final Continuation<TResult, Task<TContinuationResult>> continuation) {
public @NonNull <TContinuationResult> Task<TContinuationResult> onSuccessTask(
@NonNull final Continuation<TResult, Task<TContinuationResult>> continuation) {
return onSuccessTask(continuation, IMMEDIATE_EXECUTOR);
}
@@ -834,8 +850,9 @@ public class Task<TResult> {
* Runs a continuation when a task completes successfully, forwarding along {@link
* java.lang.Exception}s or cancellation.
*/
public <TContinuationResult> Task<TContinuationResult> onSuccessTask(
final Continuation<TResult, Task<TContinuationResult>> continuation, CancellationToken ct) {
public @NonNull <TContinuationResult> Task<TContinuationResult> onSuccessTask(
@NonNull final Continuation<TResult, Task<TContinuationResult>> continuation,
@Nullable CancellationToken ct) {
return onSuccessTask(continuation, IMMEDIATE_EXECUTOR, ct);
}
@@ -851,11 +868,11 @@ public class Task<TResult> {
* be scheduled on a different thread).
*/
private static <TContinuationResult, TResult> void completeImmediately(
final TaskCompletionSource<TContinuationResult> tcs,
final Continuation<TResult, TContinuationResult> continuation,
final Task<TResult> task,
Executor executor,
final CancellationToken ct) {
@NonNull final TaskCompletionSource<TContinuationResult> tcs,
@NonNull final Continuation<TResult, TContinuationResult> continuation,
@NonNull final Task<TResult> task,
@NonNull Executor executor,
@Nullable final CancellationToken ct) {
try {
executor.execute(
new Runnable() {
@@ -894,11 +911,11 @@ public class Task<TResult> {
* be scheduled on a different thread).
*/
private static <TContinuationResult, TResult> void completeAfterTask(
final TaskCompletionSource<TContinuationResult> tcs,
final Continuation<TResult, Task<TContinuationResult>> continuation,
final Task<TResult> task,
final Executor executor,
final CancellationToken ct) {
@NonNull final TaskCompletionSource<TContinuationResult> tcs,
@NonNull final Continuation<TResult, Task<TContinuationResult>> continuation,
@NonNull final Task<TResult> task,
@NonNull final Executor executor,
@Nullable final CancellationToken ct) {
try {
executor.execute(
new Runnable() {
@@ -917,7 +934,7 @@ public class Task<TResult> {
result.continueWith(
new Continuation<TContinuationResult, Void>() {
@Override
public Void then(Task<TContinuationResult> task) {
public Void then(@NonNull Task<TContinuationResult> task) {
if (ct != null && ct.isCancellationRequested()) {
tcs.setCancelled();
return null;
@@ -976,7 +993,7 @@ public class Task<TResult> {
}
/** Sets the result on the Task if the Task hasn't already been completed. */
/* package */ boolean trySetResult(TResult result) {
/* package */ boolean trySetResult(@Nullable TResult result) {
synchronized (lock) {
if (complete) {
return false;
@@ -990,7 +1007,7 @@ public class Task<TResult> {
}
/** Sets the error on the Task if the Task hasn't already been completed. */
/* package */ boolean trySetError(Exception error) {
/* package */ boolean trySetError(@Nullable Exception error) {
synchronized (lock) {
if (complete) {
return false;
@@ -1006,8 +1023,8 @@ public class Task<TResult> {
}
}
private static Task<?> TASK_NULL = new Task<>(null);
private static Task<Boolean> TASK_TRUE = new Task<>((Boolean) true);
private static Task<Boolean> TASK_FALSE = new Task<>((Boolean) false);
private static Task<?> TASK_CANCELLED = new Task(true);
private static final Task<?> TASK_NULL = new Task<>(null);
private static final Task<Boolean> TASK_TRUE = new Task<>((Boolean) true);
private static final Task<Boolean> TASK_FALSE = new Task<>((Boolean) false);
private static final Task<?> TASK_CANCELLED = new Task(true);
}