mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Fixing unreachable-code-return in react-native-github (#56093)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56093 ## Changelog [iOS][Fixed] - Addressing -Wunreachable-code-return issues. Reviewed By: javache Differential Revision: D96507093 fbshipit-source-id: 58f293b4978237cffa301c5518bf6aded9c3001c
This commit is contained in:
1 parent
7f2a58e46c
commit
722623aaeb
2 files changed
+1
-1
No files matched your search
@@ -315,6 +315,7 @@ void RCTProfileHookModules(RCTBridge *bridge)
|
||||
|
||||
#pragma clang diagnostic push
|
||||
#pragma clang diagnostic ignored "-Wtautological-pointer-compare"
|
||||
#pragma clang diagnostic ignored "-Wunreachable-code-return"
|
||||
if (RCTProfileTrampoline == NULL) {
|
||||
return;
|
||||
}
|
||||
|
||||
-1
@@ -156,7 +156,6 @@ convertJSIFunctionToCallback(jsi::Runtime &rt, jsi::Function &&function, const s
|
||||
return ^(NSArray *args) {
|
||||
if (!callback) {
|
||||
LOG(FATAL) << "Callback arg cannot be called more than once";
|
||||
return;
|
||||
}
|
||||
|
||||
callback->call([args](jsi::Runtime &rt, jsi::Function &jsFunction) {
|
||||
|
||||
Reference in new issue
Block a user