Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename sliceChildShadowNodeViewPairsLegacy -> sliceChildShadowNodeViewPairsForTesting (#42928)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/42928

Rename sliceChildShadowNodeViewPairsLegacy -> sliceChildShadowNodeViewPairsForTesting

changelog: [internal] internal

Reviewed By: rshest

Differential Revision: D53546236

fbshipit-source-id: a1590880360a7ae072cafeeead29d929f00e551d
This commit is contained in:
David Vacca
2024-02-11 21:02:39 -08:00
committed by Facebook GitHub Bot
parent b5d9974169
commit 710ff5f4c9
3 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/react/renderer/mounting/Differentiator.cpp
+5 -4
View File
@@ -1556,7 +1556,7 @@ static void calculateShadowViewMutationsV2(
/**
* Only used by unit tests currently.
*/
static void sliceChildShadowNodeViewPairsRecursivelyLegacy(
static void sliceChildShadowNodeViewPairsRecursivelyForTesting(
ShadowViewNodePair::OwningList& pairList,
Point layoutOffset,
const ShadowNode& shadowNode) {
@@ -1587,7 +1587,7 @@ static void sliceChildShadowNodeViewPairsRecursivelyLegacy(
pairList.push_back({shadowView, &childShadowNode});
}
sliceChildShadowNodeViewPairsRecursivelyLegacy(
sliceChildShadowNodeViewPairsRecursivelyForTesting(
pairList, origin, childShadowNode);
}
}
@@ -1596,7 +1596,7 @@ static void sliceChildShadowNodeViewPairsRecursivelyLegacy(
/**
* Only used by unit tests currently.
*/
ShadowViewNodePair::OwningList sliceChildShadowNodeViewPairsLegacy(
ShadowViewNodePair::OwningList sliceChildShadowNodeViewPairsForTesting(
const ShadowNode& shadowNode) {
auto pairList = ShadowViewNodePair::OwningList{};
@@ -1606,7 +1606,8 @@ ShadowViewNodePair::OwningList sliceChildShadowNodeViewPairsLegacy(
return pairList;
}
sliceChildShadowNodeViewPairsRecursivelyLegacy(pairList, {0, 0}, shadowNode);
sliceChildShadowNodeViewPairsRecursivelyForTesting(
pairList, {0, 0}, shadowNode);
return pairList;
}
packages/react-native/ReactCommon/react/renderer/mounting/Differentiator.h
+1 -1
View File
@@ -63,7 +63,7 @@ ShadowViewNodePair::NonOwningList sliceChildShadowNodeViewPairsV2(
* Generates a list of `ShadowViewNodePair`s that represents a layer of a
* flattened view hierarchy. This is *only* used by unit tests currently.
*/
ShadowViewNodePair::OwningList sliceChildShadowNodeViewPairsLegacy(
ShadowViewNodePair::OwningList sliceChildShadowNodeViewPairsForTesting(
const ShadowNode& shadowNode);
} // namespace facebook::react
packages/react-native/ReactCommon/react/renderer/mounting/stubs.cpp
+2 -2
View File
@@ -55,7 +55,7 @@ static void calculateShadowViewMutationsForNewTree(
parentShadowView, newChildPair.shadowView, static_cast<int>(index)));
auto newGrandChildPairs =
sliceChildShadowNodeViewPairsLegacy(*newChildPair.shadowNode);
sliceChildShadowNodeViewPairsForTesting(*newChildPair.shadowNode);
calculateShadowViewMutationsForNewTree(
mutations, newChildPair.shadowView, newGrandChildPairs);
@@ -70,7 +70,7 @@ StubViewTree buildStubViewTreeWithoutUsingDifferentiator(
calculateShadowViewMutationsForNewTree(
mutations,
ShadowView(rootShadowNode),
sliceChildShadowNodeViewPairsLegacy(rootShadowNode));
sliceChildShadowNodeViewPairsForTesting(rootShadowNode));
auto emptyRootShadowNode = rootShadowNode.clone(ShadowNodeFragment{
ShadowNodeFragment::propsPlaceholder(),