mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Stop render callback on destruction to prevent crash (#51558)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51558 changelog: [internal] we must call stopRenderCallbackIfNeeded to prevent UI tick from being called when `NativeAnimatedNodesManager` is deallocated. Reviewed By: mdvacca Differential Revision: D75140890 fbshipit-source-id: 9ad32956a877f9ee8256790ba32cb5982a5b0c2f
This commit is contained in:
1 parent
a633d93f7f
commit
6ff500d694
2 files changed
+7
-3
No files matched your search
+5
-1
@@ -65,6 +65,10 @@ NativeAnimatedNodesManager::NativeAnimatedNodesManager(
|
||||
startOnRenderCallback_(std::move(startOnRenderCallback)),
|
||||
stopOnRenderCallback_(std::move(stopOnRenderCallback)) {}
|
||||
|
||||
NativeAnimatedNodesManager::~NativeAnimatedNodesManager() noexcept {
|
||||
stopRenderCallbackIfNeeded();
|
||||
}
|
||||
|
||||
std::optional<double> NativeAnimatedNodesManager::getValue(Tag tag) {
|
||||
auto node = getAnimatedNode<ValueAnimatedNode>(tag);
|
||||
if (node) {
|
||||
@@ -466,7 +470,7 @@ void NativeAnimatedNodesManager::startRenderCallbackIfNeeded() {
|
||||
}
|
||||
}
|
||||
|
||||
void NativeAnimatedNodesManager::stopRenderCallbackIfNeeded() {
|
||||
void NativeAnimatedNodesManager::stopRenderCallbackIfNeeded() noexcept {
|
||||
if (stopOnRenderCallback_) {
|
||||
stopOnRenderCallback_();
|
||||
}
|
||||
|
||||
+2
-2
@@ -57,7 +57,7 @@ class NativeAnimatedNodesManager
|
||||
StartOnRenderCallback&& startOnRenderCallback = nullptr,
|
||||
StopOnRenderCallback&& stopOnRenderCallback = nullptr) noexcept;
|
||||
|
||||
~NativeAnimatedNodesManager() = default;
|
||||
~NativeAnimatedNodesManager() noexcept;
|
||||
|
||||
template <
|
||||
typename T,
|
||||
@@ -173,7 +173,7 @@ class NativeAnimatedNodesManager
|
||||
bool isOnRenderThread() const;
|
||||
|
||||
private:
|
||||
void stopRenderCallbackIfNeeded();
|
||||
void stopRenderCallbackIfNeeded() noexcept;
|
||||
|
||||
bool onAnimationFrame(uint64_t timestamp);
|
||||
|
||||
|
||||
Reference in new issue
Block a user