Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove Deprecated TurboModuleManagerDelegate APIs

Browse Source 
Summary:
This deprecated API makes TurboModuleManager's module creation algorithm harder to follow. Let's remove it.

Changelog: [Android][Removed] - Remove TurboModuleManagerDelegate.getLegacyCxxModule

Reviewed By: mdvacca

Differential Revision: D45158031

fbshipit-source-id: f72af3d62e51a4c8427d41975f51d1c9dd31c6c8
This commit is contained in:
Ramanpreet Nara
2023-04-21 16:37:04 -07:00
committed by Facebook GitHub Bot
parent ac2a4d8e6c
commit 6f10110555
3 changed files with 1 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageTurboModuleManagerDelegate.java
-7
View File
@@ -219,13 +219,6 @@ public abstract class ReactPackageTurboModuleManagerDelegate extends TurboModule
return resolvedModule;
}
@Deprecated
@Nullable
@Override
public CxxModuleWrapper getLegacyCxxModule(String moduleName) {
return null;
}
@Override
public List<String> getEagerInitModuleNames() {
List<String> moduleNames = new ArrayList<>();
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java
+1 -15
View File
@@ -75,21 +75,7 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
mTurboModuleProvider =
delegate == null
? nullProvider
: moduleName -> {
NativeModule module = (NativeModule) delegate.getModule(moduleName);
if (module == null) {
CxxModuleWrapper legacyCxxModule = delegate.getLegacyCxxModule(moduleName);
if (legacyCxxModule != null) {
// TurboModuleManagerDelegate.getLegacyCxxModule() must always return TurboModules
Assertions.assertCondition(
legacyCxxModule instanceof TurboModule,
"CxxModuleWrapper \"" + moduleName + "\" is not a TurboModule");
return legacyCxxModule;
}
}
return module;
};
: moduleName -> (NativeModule) delegate.getModule(moduleName);
mLegacyModuleProvider =
delegate == null || !shouldCreateLegacyModules()
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManagerDelegate.java
-11
View File
@@ -10,7 +10,6 @@ package com.facebook.react.turbomodule.core;
import androidx.annotation.Nullable;
import com.facebook.jni.HybridData;
import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.bridge.CxxModuleWrapper;
import com.facebook.react.bridge.NativeModule;
import com.facebook.react.turbomodule.core.interfaces.TurboModule;
import com.facebook.soloader.SoLoader;
@@ -39,16 +38,6 @@ public abstract class TurboModuleManagerDelegate {
@Nullable
public abstract TurboModule getModule(String moduleName);
/**
* Create and return a CxxModuleWrapper NativeModule with name `moduleName`. If `moduleName` isn't
* a CxxModule, return null. CxxModuleWrapper must implement TurboModule.
*
* <p>Deprecated. Please just return your CxxModuleWrappers from getModule.
*/
@Deprecated
@Nullable
public abstract CxxModuleWrapper getLegacyCxxModule(String moduleName);
/**
* Create an return a legacy NativeModule with name `moduleName`. If `moduleName` is a
* TurboModule, return null.