mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Cover react/nativemodule/featureflags with Stable API guards (#58041)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58041 Classifies `react/nativemodule/featureflags:featureflags` as a private target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include its header directly; without that flag the guard is inert, so no existing build changes behaviour. `NativeReactNativeFeatureFlags.h` is generated, so the guard is added to its template and the file regenerated with `yarn featureflags --update` rather than edited in place. Changelog: [Internal] Reviewed By: javache Differential Revision: D116916158 fbshipit-source-id: 7fd9ab146d4dff33976f67b72202b9b4ed87ad03
This commit is contained in:
1 parent
6bee68d37e
commit
6e7d5bfebb
4 files changed
+7
-1
No files matched your search
@@ -16,6 +16,7 @@ target_include_directories(react_nativemodule_featureflags PUBLIC ${REACT_COMMON
|
||||
target_link_libraries(react_nativemodule_featureflags
|
||||
react_codegen_rncore
|
||||
react_cxxreact
|
||||
react_cxxstableapi
|
||||
react_featureflags
|
||||
)
|
||||
target_compile_reactnative_options(react_nativemodule_featureflags PRIVATE)
|
||||
|
||||
+3
-1
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<c65d5fea853b54322321f86c1d5ce440>>
|
||||
* @generated SignedSource<<40d25fafea07a23f9d4e146973c65cb5>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -19,6 +19,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/PrivateGuard.h>
|
||||
|
||||
#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple
|
||||
#include "FBReactNativeSpecJSI.h"
|
||||
#else
|
||||
|
||||
+1
@@ -50,6 +50,7 @@ Pod::Spec.new do |s|
|
||||
s.dependency "ReactCommon/turbomodule/core"
|
||||
s.dependency "React-RCTFBReactNativeSpec"
|
||||
s.dependency "React-featureflags"
|
||||
s.dependency "React-cxxstableapi"
|
||||
|
||||
mark_as_react_native_build(s)
|
||||
end
|
||||
+2
@@ -27,6 +27,8 @@ ${DO_NOT_MODIFY_COMMENT}
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/PrivateGuard.h>
|
||||
|
||||
#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple
|
||||
#include "FBReactNativeSpecJSI.h"
|
||||
#else
|
||||
|
||||
Reference in new issue
Block a user