Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Removing a couple of (ViewProps and YogaStylableProps) constructors

Browse Source 
Summary:
Here we delete several constructors that were needed only because `YogaLayoutableShadowNode::yogaStyle` was private (which is not true anymore).

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: sammy-SC, mdvacca

Differential Revision: D20052033

fbshipit-source-id: c2afcaf2fdebb65cdcde6c214c8b78aa35d45e91
This commit is contained in:
Valentin Shergin
2020-02-26 22:08:20 -08:00
committed by Facebook Github Bot
parent cdbc21132b
commit 6d10310733
5 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/fabric/components/root/RootProps.cpp
+4 -2
View File
@@ -39,9 +39,11 @@ RootProps::RootProps(
RootProps const &sourceProps,
LayoutConstraints const &layoutConstraints,
LayoutContext const &layoutContext)
: ViewProps(yogaStyleFromLayoutConstraints(layoutConstraints)),
: ViewProps(),
layoutConstraints(layoutConstraints),
layoutContext(layoutContext){};
layoutContext(layoutContext) {
yogaStyle = yogaStyleFromLayoutConstraints(layoutConstraints);
};
} // namespace react
} // namespace facebook
ReactCommon/fabric/components/view/ViewProps.cpp
-2
View File
@@ -18,8 +18,6 @@
namespace facebook {
namespace react {
ViewProps::ViewProps(YGStyle const &yogaStyle) : YogaStylableProps(yogaStyle) {}
ViewProps::ViewProps(ViewProps const &sourceProps, RawProps const &rawProps)
: Props(sourceProps, rawProps),
YogaStylableProps(sourceProps, rawProps),
ReactCommon/fabric/components/view/ViewProps.h
-1
View File
@@ -28,7 +28,6 @@ class ViewProps : public Props,
public AccessibilityProps {
public:
ViewProps() = default;
ViewProps(YGStyle const &yogaStyle);
ViewProps(ViewProps const &sourceProps, RawProps const &rawProps);
#pragma mark - Props
ReactCommon/fabric/components/view/yoga/YogaStylableProps.cpp
-3
View File
@@ -19,9 +19,6 @@
namespace facebook {
namespace react {
YogaStylableProps::YogaStylableProps(YGStyle const &yogaStyle)
: yogaStyle(yogaStyle) {}
YogaStylableProps::YogaStylableProps(
YogaStylableProps const &sourceProps,
RawProps const &rawProps)
ReactCommon/fabric/components/view/yoga/YogaStylableProps.h
-1
View File
@@ -18,7 +18,6 @@ namespace react {
class YogaStylableProps {
public:
YogaStylableProps() = default;
YogaStylableProps(YGStyle const &yogaStyle);
YogaStylableProps(
YogaStylableProps const &sourceProps,
RawProps const &rawProps);