Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: ReactHost: Rename {new,old}Start to {new,old}GetOrCreateStartTask (#42166)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/42166

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D52495535

fbshipit-source-id: 736e2c512710db0a51a5370a4f7e97ea87a7ce23
This commit is contained in:
Ramanpreet Nara
2024-01-09 19:07:01 -08:00
committed by Facebook GitHub Bot
parent 466deff0de
commit 6b79c14e33
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java
+10 -8
View File
@@ -202,10 +202,10 @@ public class ReactHostImpl implements ReactHost {
@Override
public TaskInterface<Void> start() {
if (ReactFeatureFlags.enableBridgelessArchitectureNewCreateReloadDestroy) {
return newStart();
return newGetOrCreateStartTask();
}
return oldStart();
return oldGetOrCreateStartTask();
}
/** Initialize and run a React Native surface in a background without mounting real views. */
@@ -719,8 +719,8 @@ public class ReactHostImpl implements ReactHost {
@ThreadConfined("ReactHost")
private @Nullable Task<Void> mStartTask = null;
private Task<Void> oldStart() {
final String method = "oldStart()";
private Task<Void> oldGetOrCreateStartTask() {
final String method = "oldGetOrCreateStartTask()";
return Task.call(
() -> {
if (mStartTask == null) {
@@ -731,7 +731,8 @@ public class ReactHostImpl implements ReactHost {
task -> {
if (task.isFaulted()) {
destroy(
"oldStart() failure: " + task.getError().getMessage(),
"oldGetOrCreateStartTask() failure: "
+ task.getError().getMessage(),
task.getError());
mReactHostDelegate.handleInstanceException(task.getError());
}
@@ -747,8 +748,8 @@ public class ReactHostImpl implements ReactHost {
.continueWithTask(Task::getResult);
}
private Task<Void> newStart() {
final String method = "newStart()";
private Task<Void> newGetOrCreateStartTask() {
final String method = "newGetOrCreateStartTask()";
return Task.call(
() -> {
if (mStartTask == null) {
@@ -761,7 +762,8 @@ public class ReactHostImpl implements ReactHost {
mReactHostDelegate.handleInstanceException(task.getError());
// Wait for destroy to finish
return newGetOrCreateDestroyTask(
"newStart() failure: " + task.getError().getMessage(),
"newGetOrCreateStartTask() failure: "
+ task.getError().getMessage(),
task.getError())
.continueWithTask(destroyTask -> Task.forError(task.getError()))
.makeVoid();