Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Send Profile in smaller chunk to prevent WebSocket disconnections on android (#50337)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/50337

# Changelog: [Internal]

This should not have any functional changes, it only prevents the WebSocket from being killed on Android, when we are sending Profile-related Trace Events.

For large traces, a single message could be more than 16MB, because we send a unique string url for every call frame.

Reviewed By: huntie

Differential Revision: D71993748

fbshipit-source-id: f0bfddfb0bb87631e72b573142abdf0d7d87ba48
This commit is contained in:
Ruslan Lesiutin
2025-03-28 05:43:41 -07:00
committed by Facebook GitHub Bot
parent c6eb714035
commit 6b72fd2dbf
2 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/jsinspector-modern/TracingAgent.cpp
+10 -1
View File
@@ -20,6 +20,15 @@ namespace {
*/
const uint16_t TRACE_EVENT_CHUNK_SIZE = 1000;
/**
* The maximum number of ProfileChunk trace events
* that will be sent in a single CDP Tracing.dataCollected message.
* TODO(T219394401): Increase the size once we manage the queue on OkHTTP side
* properly and avoid WebSocket disconnections when sending a message larger
* than 16MB.
*/
const uint16_t PROFILE_TRACE_EVENT_CHUNK_SIZE = 1;
} // namespace
bool TracingAgent::handleRequest(const cdp::PreparsedRequest& req) {
@@ -89,7 +98,7 @@ bool TracingAgent::handleRequest(const cdp::PreparsedRequest& req) {
instanceAgent_->collectTracingProfile().getRuntimeSamplingProfile(),
instanceTracingStartTimestamp_,
dataCollectedCallback,
TRACE_EVENT_CHUNK_SIZE);
PROFILE_TRACE_EVENT_CHUNK_SIZE);
frontendChannel_(cdp::jsonNotification(
"Tracing.tracingComplete",
packages/react-native/ReactCommon/jsinspector-modern/tracing/RuntimeSamplingProfileTraceEventSerializer.h
+14 -1
View File
@@ -20,6 +20,19 @@ class RuntimeSamplingProfileTraceEventSerializer {
public:
RuntimeSamplingProfileTraceEventSerializer() = delete;
/**
* \param performanceTracer A reference to PerformanceTracer instance.
* \param profile What we will be serializing.
* \param tracingStartTime A timestamp of when tracing of an
* Instance started, will be used as a starting reference point of JavaScript
* samples recording.
* \param notificationCallback A callback, which is called
* when a chunk of trace events is ready to be sent.
* \param traceEventChunkSize The maximum number of ProfileChunk trace events
* that can be sent in a single CDP Tracing.dataCollected message.
* \param profileChunkSize The maximum number of ProfileChunk trace events
* that can be sent in a single ProfileChunk trace event.
*/
static void serializeAndNotify(
PerformanceTracer& performanceTracer,
const RuntimeSamplingProfile& profile,
@@ -27,7 +40,7 @@ class RuntimeSamplingProfileTraceEventSerializer {
const std::function<void(const folly::dynamic& traceEventsChunk)>&
notificationCallback,
uint16_t traceEventChunkSize,
uint16_t profileChunkSize = 100);
uint16_t profileChunkSize = 10);
};
} // namespace facebook::react::jsinspector_modern::tracing