Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: Rename TurboModule create method to getOrCreateModule()

Browse Source 
Summary:
Readability.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D43801530

fbshipit-source-id: c33ac91af4614804c5b6566776a1650d4f7855f4
This commit is contained in:
Ramanpreet Nara
2023-03-11 16:59:39 -08:00
committed by Facebook GitHub Bot
parent c1c17e299e
commit 6b42b86620
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java
+3 -3
View File
@@ -154,7 +154,7 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
}
TurboModulePerfLogger.moduleCreateStart(moduleName, moduleHolder.getModuleId());
TurboModule module = getModule(moduleName, moduleHolder, true);
TurboModule module = getOrCreateModule(moduleName, moduleHolder, true);
if (module != null) {
TurboModulePerfLogger.moduleCreateEnd(moduleName, moduleHolder.getModuleId());
@@ -172,7 +172,7 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
* first thread creates x. All n - 1 other threads wait until the x is created and initialized.
*/
@Nullable
private TurboModule getModule(
private TurboModule getOrCreateModule(
String moduleName, @NonNull ModuleHolder moduleHolder, boolean shouldPerfLog) {
boolean shouldCreateModule = false;
@@ -321,7 +321,7 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
* initialized. In this case, we should wait for initialization to complete, before destroying
* the TurboModule.
*/
final TurboModule turboModule = getModule(moduleName, moduleHolder, false);
final TurboModule turboModule = getOrCreateModule(moduleName, moduleHolder, false);
if (turboModule != null) {
turboModule.invalidate();