Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix concurrent consumers issue with ReactMarker (#38710)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38710

Fix a race condition when multiple consumers try to access ReactMarker and trigger calls to native module. Even though ReactMarker uses `ConcurrentLinkedQueue`, the loop itself could race and cause NPE.

Changelog:
[Android][Fixed] - Fix race condition with ReactMarker calls to its native module

Reviewed By: rshest

Differential Revision: D47933993

fbshipit-source-id: a56e5e4f3564922d534235991da5b6842248bf24
This commit is contained in:
Xin Chen
2023-08-01 12:19:17 -07:00
committed by Facebook GitHub Bot
parent 743799078b
commit 6ab062dfec
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactMarker.java
+2 -2
View File
@@ -193,8 +193,8 @@ public class ReactMarker {
nativeLogMarker(name.name(), now);
// Then send all cached native ReactMarkers
while (!sNativeReactMarkerQueue.isEmpty()) {
ReactMarkerRecord record = sNativeReactMarkerQueue.poll();
ReactMarkerRecord record;
while ((record = sNativeReactMarkerQueue.poll()) != null) {
nativeLogMarker(record.getMarkerName(), record.getMarkerTime());
}
} else {