Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix[dynamic-scripts-injection]: unregister content scripts before registration (#26765)

Browse Source 
Summary:
## Summary
Fixes #26756.

DevTools is failing to inject `__REACT_DEVTOOLS_GLOBAL_HOOK__` hook in
incognito mode. This is not happening straight-forward, but if extension
is toggled on and off, the next time I try to open it I am receiving an
error that content script was already registered.

<img width="676" alt="Screenshot 2023-05-02 at 14 36 53"
src="https://user-images.githubusercontent.com/28902667/235877692-51c5d284-79d9-4b00-b62e-d25d5bb5e056.png">

- Unregistering content scripts before attempting to register them
again. We need to inject `__REACT_DEVTOOLS_GLOBAL_HOOK__` on each page,
so this should be expected behaviour.
- Fixed error logging

## How did you test this change?
Local build of extension for Chrome, trying the same steps, which
resulted in an error.
No regression in performance, tested on react.dev, still the same.

DiffTrain build for commit https://github.com/facebook/react/commit/8a25302c668d6f9a24f6680fb4947e9b388bb7d9.

Changelog: [Internal]:
<< DO NOT EDIT BELOW THIS LINE >>

Reviewed By: sammy-SC

Differential Revision: D45532160

Pulled By: tyao1

fbshipit-source-id: d021721a4aee3e052512006f61cfdf72df56dbda
This commit is contained in:
hoxyq (Meta Employee)
2023-05-05 16:36:15 -07:00
committed by Facebook GitHub Bot
parent bebd8d0470
commit 6892a15a71
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/Renderer/REVISION
+1 -1
View File
@@ -1 +1 @@
2c2476834a7c739ca239750b73f74aa1df144a93
8a25302c668d6f9a24f6680fb4947e9b388bb7d9