mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
A fix in Codegen for Windows build host (#36542)
Summary: Android builds with new arch fail on Windows build host (https://github.com/facebook/react-native/issues/36475). This tiny correction fixes generation of `schema.json` (without it codegen failed to find any files, and generated empty schema). Unfortunately, does not fixes the issue with Windows host entirely, as builds still fail later (on ninja build step). ## Changelog: [Android] [Fixed] - A bug fix for Android builds with new arch on Windows host. Pull Request resolved: https://github.com/facebook/react-native/pull/36542 Reviewed By: NickGerleman Differential Revision: D48563587 Pulled By: cortinico fbshipit-source-id: acd510308ce9768fb17d3a33c7927de3237748ac
This commit is contained in:
@@ -14,6 +14,7 @@
|
||||
const combine = require('./combine-js-to-schema');
|
||||
const fs = require('fs');
|
||||
const glob = require('glob');
|
||||
const path = require('path');
|
||||
const {parseArgs, filterJSFile} = require('./combine-utils');
|
||||
|
||||
const {platform, outfile, fileList} = parseArgs(process.argv);
|
||||
@@ -21,9 +22,14 @@ const {platform, outfile, fileList} = parseArgs(process.argv);
|
||||
const allFiles = [];
|
||||
fileList.forEach(file => {
|
||||
if (fs.lstatSync(file).isDirectory()) {
|
||||
const filePattern = path.sep === '\\' ? file.replace(/\\/g, '/') : file;
|
||||
const dirFiles = glob
|
||||
.sync(`${file}/**/*.{js,ts,tsx}`, {
|
||||
.sync(`${filePattern}/**/*.{js,ts,tsx}`, {
|
||||
nodir: true,
|
||||
// TODO: This will remove the need of slash substitution above for Windows,
|
||||
// but it requires glob@v9+; with the package currenlty relying on
|
||||
// glob@7.1.1; and flow-typed repo not having definitions for glob@9+.
|
||||
// windowsPathsNoEscape: true,
|
||||
})
|
||||
.filter(element => filterJSFile(element, platform));
|
||||
allFiles.push(...dirFiles);
|
||||
|
||||
Reference in New Issue
Block a user