Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change feature flag default for initEagerTurboModulesOnNativeModulesQueueAndroid (#47566)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/47566

Changelog: [Android][Changed] TurboModules marked as requiring eager init will now be constructed on the mqt_native thread to increase concurrency in React Native init.

Reviewed By: rshest

Differential Revision: D65661887

fbshipit-source-id: c1863ea44771de5caedc2968a325abcc7022c792
This commit is contained in:
Pieter De Baets
2024-11-13 04:00:19 -08:00
committed by Facebook GitHub Bot
parent dc8c2f676e
commit 663b5f9d19
4 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
+2 -2
View File
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<43c2b02a67fea9ad6d36e7716cb81ccc>>
* @generated SignedSource<<d2d9a8abf3e0be78bbe20c44fce1011d>>
*/
/**
@@ -87,7 +87,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
override fun fuseboxEnabledRelease(): Boolean = false
override fun initEagerTurboModulesOnNativeModulesQueueAndroid(): Boolean = false
override fun initEagerTurboModulesOnNativeModulesQueueAndroid(): Boolean = true
override fun lazyAnimationCallbacks(): Boolean = false
packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h
+2 -2
View File
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<ec502f5beacb2119c3fb1f319a95dfc9>>
* @generated SignedSource<<50402601a833b4a74d39733dcbd9ef65>>
*/
/**
@@ -156,7 +156,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}
bool initEagerTurboModulesOnNativeModulesQueueAndroid() override {
return false;
return true;
}
bool lazyAnimationCallbacks() override {
packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
+2 -3
View File
@@ -319,12 +319,11 @@ const definitions: FeatureFlagDefinitions = {
},
},
initEagerTurboModulesOnNativeModulesQueueAndroid: {
defaultValue: false,
defaultValue: true,
metadata: {
dateAdded: '2024-07-11',
description:
'Construct modules that requires eager init on the dedicate native modules thread',
purpose: 'experimentation',
purpose: 'release',
},
},
lazyAnimationCallbacks: {
packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
Vendored
+2 -2
View File
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d01ef9b03c2a4aac3a5ca77dc25ec7c3>>
* @generated SignedSource<<ee28bd585298c2e510a11433b64c76a9>>
* @flow strict
*/
@@ -319,7 +319,7 @@ export const fuseboxEnabledRelease: Getter<boolean> = createNativeFlagGetter('fu
/**
* Construct modules that requires eager init on the dedicate native modules thread
*/
export const initEagerTurboModulesOnNativeModulesQueueAndroid: Getter<boolean> = createNativeFlagGetter('initEagerTurboModulesOnNativeModulesQueueAndroid', false);
export const initEagerTurboModulesOnNativeModulesQueueAndroid: Getter<boolean> = createNativeFlagGetter('initEagerTurboModulesOnNativeModulesQueueAndroid', true);
/**
* Only enqueue Choreographer calls if there is an ongoing animation, instead of enqueueing every frame.
*/