Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cache vector image detection for assets (#46415)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/46415

Changelog: [Internal]

Cache the results checking for vector content. This check is decompressing the asset content and parsing XML to check for vector graphics. Caching the result per context/asset name removes the need to parse the content on each image assignment.

Reviewed By: Abbondanzo

Differential Revision: D62436412

fbshipit-source-id: 9e1fe9f0747c9a30ac0d89124b6909d4260a2a2f
This commit is contained in:
Nick Lefever
2024-09-10 09:20:08 -07:00
committed by Facebook GitHub Bot
parent 4a22f2c816
commit 65beadb00a
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/imagehelper/ResourceDrawableIdHelper.kt
+10 -1
View File
@@ -19,6 +19,7 @@ import org.xmlpull.v1.XmlPullParser
@ThreadSafe
public class ResourceDrawableIdHelper private constructor() {
private val resourceDrawableIdMap: MutableMap<String, Int> = HashMap()
private val vectorDrawableCheckCache: MutableMap<Context, MutableMap<String, Boolean>> = HashMap()
@Synchronized
public fun clear() {
@@ -64,7 +65,15 @@ public class ResourceDrawableIdHelper private constructor() {
}
public fun isVectorDrawable(context: Context, name: String): Boolean {
return getOpeningXmlTag(context, name) == "vector"
val cachedResult = vectorDrawableCheckCache[context]?.get(name);
if (cachedResult != null) {
return cachedResult
}
val result = getOpeningXmlTag(context, name) == "vector"
vectorDrawableCheckCache.getOrPut(context, { HashMap() }).put(name, result)
return result
}
/**