Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix detection of android emulator (#35111)

Browse Source 
Summary:
at some point, the `Build.FINGERPRINT` of the emulator has changed and no longer includes `generic` as an option.

It apparently now, on all platforms, includes `google/sdk_gphone` at the beginning. Older emulators may still include `generic` in the `Build.FINGERPRINT` so we should maintain that check too.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Android] [Fixed] - Fix android emulator detection for packager host

Pull Request resolved: https://github.com/facebook/react-native/pull/35111

Test Plan: When running on a modern emulator, ensure that the packager attempts to load from `10.0.2.2`.

Reviewed By: cipolleschi

Differential Revision: D41266071

Pulled By: GijsWeterings

fbshipit-source-id: 43115dbde6a411fe2ebde23e720dff4812a4309f
This commit is contained in:
David Buchan-Swanson
2022-11-15 07:20:36 -08:00
committed by Facebook GitHub Bot
parent adee7be5d8
commit 64ff077a66
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/AndroidInfoHelpers.java
+2 -1
View File
@@ -32,7 +32,8 @@ public class AndroidInfoHelpers {
}
private static boolean isRunningOnStockEmulator() {
return Build.FINGERPRINT.contains("generic");
return Build.FINGERPRINT.contains("generic")
|| Build.FINGERPRINT.startsWith("google/sdk_gphone");
}
public static String getServerHost(Integer port) {